Skip to content

Commit 9dd6987

Browse files
scaffold: fix duration_s and cleanline_status checks
The agent's Phase 1 QA-table checklist had two factual errors that would have caused false positives on every subject: - duration_s is wall-clock processing time (toc inside the per-subject try-catch), not recording duration. Compare across subjects; do not compare against ThePresent's ~210 s length. - cleanline_status values are the literal strings 'applied' or 'skipped_nyquist' (per conditional_cleanline.m). Update the rule to match. Caught while staging the first re-run results from the 3-subject Phase 1 batch. Refs #1.
1 parent 365e183 commit 9dd6987

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.claude/agents/eeg-qa-neuroscientist.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ QA-table checks:
4444
- `rejected_channels` must contain `Cz` for every subject; not having Cz means the reference was reconstructed and the rest of the pipeline is invalid.
4545
- `n_channels_after` distribution sanity: 90-128 is typical. Below 80 means an unusually bad recording or threshold mis-set. Flag subjects below 90 individually with the rejection count + reason.
4646
- `srate` must be 100 for every subject (local 100 Hz tier). 500 means the wrong dataset was loaded.
47-
- `duration_s` should be roughly comparable across subjects for the same task (`ThePresent` ~3.5 min, ≈ 210 s; tolerate ±10%).
48-
- `cleanline_status` should be `"skipped (srate<500)"` for every 100 Hz subject. Anything else is a finding.
47+
- `duration_s` is wall-clock processing time per subject (seconds spent inside `process_one_subject`), not recording duration. Compare across subjects to spot stragglers; do not compare against task length.
48+
- `cleanline_status` is one of the literal strings `applied` or `skipped_nyquist`. For 100 Hz data it must be `skipped_nyquist`; anything else is a finding.
4949

5050
Known-accepted observations (do NOT flag as defects):
5151
- Cz rejected by `clean_rawdata`, expected, documented in `.context/scratch_history.md`.

0 commit comments

Comments
 (0)