bunch of errorhandling cleanup

Author: hhvrc

src/lib/components/input/PasswordInput.svelte

@@ -65,9 +65,9 @@
           // Password is ok, return the successful validation result from the basic validation step
           validationResult = { valid: true };
         }
-      } catch (e) {
+      } catch (error) {
         // Show an error toast
-        await handleApiError(e);
+        await handleApiError(error);
 
         // We shouldnt block the user from submitting the form if the pwned password check fails
         validationResult = { valid: true };

src/lib/components/input/UsernameInput.svelte

@@ -54,9 +54,9 @@
 
         // Map the response to a validation result
         validationResult = mapUsernameAvailability(response.availability);
-      } catch (e) {
+      } catch (error) {
         // Show an error toast
-        await handleApiError(e);
+        await handleApiError(error);
 
         // Set the validation result to the internal server error state
         validationResult = UsernameInternalServerErrorValRes;

src/lib/errorhandling/apiErrorHandling.ts

@@ -55,7 +55,7 @@ async function handleResponseError(
   console.trace();
   console.groupEnd();
 
-  if (handleProblemCallback && !handleProblemCallback(problem)) return;
+  if (handleProblemCallback && handleProblemCallback(problem)) return;
 
   toast.error(problem.title);
 }
@@ -97,3 +97,6 @@ export async function handleApiError(
 
   toast.error('Internal error occured');
 }
+export function createApiErrorHandler(handleProblemCallback: HandleProblemCallback) {
+  return (error: unknown) => handleApiError(error, handleProblemCallback);
+}

src/lib/stores/UserStore.ts

@@ -64,7 +64,10 @@ async function refreshSelf(): Promise<boolean> {
   } catch (error) {
     reset();
 
-    handleApiError(error, (problem) => problem.type !== 'Authentication.CookieMissingOrInvalid');
+    await handleApiError(
+      error,
+      (problem) => problem.type === 'Authentication.CookieMissingOrInvalid'
+    );
 
     return false;
   }

src/routes/(anonymous)/login/+page.svelte

@@ -39,11 +39,11 @@
       await UserStore.refreshSelf();
       goto(page.url.searchParams.get('redirect') ?? '/home');
     } catch (error) {
-      handleApiError(error, (problem) => {
-        if (!isValidationError(problem)) return true;
+      await handleApiError(error, (problem) => {
+        if (!isValidationError(problem)) return false;
         usernameError = mapToValRes(problem, 'UsernameOrEmail');
         passwordError = mapToValRes(problem, 'Password');
-        return false;
+        return true;
       });
     }
   }

src/routes/(authenticated)/hubs/dialog-hub-regenerate-token.svelte

@@ -20,8 +20,8 @@
     loading = true;
     try {
       newToken = await hubManagementV1Api.devicesRegenerateDeviceToken(hub.id);
-    } catch (e) {
-      handleApiError(e);
+    } catch (error) {
+      await handleApiError(error);
     } finally {
       loading = false;
     }

src/routes/(authenticated)/settings/account/ChangeUsername.svelte

@@ -26,11 +26,11 @@
       username = '';
     } catch (e) {
       await handleApiError(e, (problem) => {
-        if (problem.type === 'Account.Username.Invalid') {
-          toast.error('Invalid Username');
-          return true;
-        }
-        return false;
+        if (problem.type !== 'Account.Username.Invalid') return false;
+
+        toast.error('Invalid Username');
+
+        return true;
       });
     }
   }

src/routes/(authenticated)/settings/sessions/+page.svelte

@@ -16,11 +16,13 @@
   import Button from '$lib/components/ui/button/button.svelte';
   import * as Card from '$lib/components/ui/card';
   import { renderComponent } from '$lib/components/ui/data-table';
+  import type { ProblemDetails } from '$lib/errorhandling/ProblemDetails';
   import { handleApiError } from '$lib/errorhandling/apiErrorHandling';
   import { onMount } from 'svelte';
   import { toast } from 'svelte-sonner';
   import DataTableActions from './data-table-actions.svelte';
 
+  let loading = $state<boolean>(false);
   let data = $state<LoginSessionResponse[]>([]);
   let sorting = $state<SortingState>([]);
 
@@ -43,11 +45,24 @@
     },
   ];
 
-  function fetchSessions() {
-    sessionsApi
-      .sessionsListSessions()
-      .then((res) => (data = res))
-      .catch(handleApiError);
+  function handleProblem(problem: ProblemDetails): boolean {
+    return false;
+  }
+
+  async function fetchSessions() {
+    loading = true;
+    try {
+      data = await sessionsApi.sessionsListSessions();
+    } catch (error) {
+      await handleApiError(error, handleProblem);
+    } finally {
+      loading = false;
+    }
+  }
+
+  async function onRefreshClicked() {
+    await fetchSessions();
+    toast.success('Sessions refreshed successfully');
   }
 
   onMount(() => {
@@ -68,13 +83,7 @@
   <Card.Header class="w-full">
     <Card.Title class="flex items-center justify-between space-x-2 text-3xl">
       Sessions
-      <Button
-        class="text-xl"
-        onclick={() => {
-          fetchSessions();
-          toast.success('Sessions refreshed successfully');
-        }}
-      >
+      <Button class="text-xl" onclick={onRefreshClicked}>
         <RotateCcw />
         <span> Refresh </span>
       </Button>

src/routes/report/api-tokens/+page.svelte

@@ -30,7 +30,7 @@
       await apiTokensApi.tokensReportTokens({ turnstileResponse, secrets });
       goto('/login');
     } catch (err) {
-      handleApiError(err);
+      await handleApiError(err);
     }
   }