fix comments

Author: hhvrc

e2e/integration/lib/test-fixtures.ts

@@ -24,10 +24,7 @@ export function makeCredentials(prefix = 'pw'): Credentials {
 
 async function applyCookiesToContext(context: BrowserContext, cookies: AuthCookies): Promise<void> {
   const url = new URL(FRONTEND_URL);
-  const apiHost = (process.env.TEST_BACKEND_URL ?? 'https://api.openshock.dev').replace(
-    /^https?:\/\//,
-    ''
-  );
+  const apiHost = new URL(process.env.TEST_BACKEND_URL ?? 'https://api.openshock.dev').hostname;
   const parsed = cookies.flatMap((raw) => {
     const [pair, ...attrs] = raw.split(';').map((s) => s.trim());
     const [name, ...rest] = pair.split('=');

e2e/integration/sessions-connections.spec.ts

@@ -21,12 +21,18 @@ test.describe('sessions page', () => {
   test('session list shows an IP address or device info', async ({ authedPage }) => {
     await authedPage.goto('/settings/sessions');
     await authedPage.waitForLoadState('networkidle');
-    // IP addresses or user-agent info should be visible in the session list
-    await expect(authedPage.locator('td, [data-ip], [data-agent]').first())
-      .toBeVisible({ timeout: 5000 })
-      .catch(() => {
-        // May use a different layout
+    // The current session must be identifiable — assert either layout-cell info
+    // or a recognizable IPv4 pattern is present somewhere on the page.
+    const cellVisible = await authedPage
+      .locator('td, [data-ip], [data-agent]')
+      .first()
+      .isVisible({ timeout: 5000 })
+      .catch(() => false);
+    if (!cellVisible) {
+      await expect(authedPage.getByText(/\b\d{1,3}(\.\d{1,3}){3}\b/).first()).toBeVisible({
+        timeout: 5000,
       });
+    }
   });
 });
 
@@ -37,14 +43,20 @@ test.describe('connections / OAuth page', () => {
     await expect(authedPage.locator('main').first()).toBeVisible();
   });
 
-  test('shows available OAuth providers', async ({ authedPage }) => {
+  test('shows available OAuth providers or an empty state', async ({ authedPage }) => {
     await authedPage.goto('/settings/connections');
     await authedPage.waitForLoadState('networkidle');
-    // Should list at least one OAuth provider (e.g. Discord, GitHub, Google)
-    await expect(authedPage.getByText(/discord|github|google|oauth|provider/i).first())
-      .toBeVisible({ timeout: 5000 })
-      .catch(() => {
-        // Page might not have any OAuth providers configured on dev backend
-      });
+    // Either provider UI is present, or an empty/none-configured state is shown.
+    // Both are acceptable — what's not acceptable is rendering nothing at all.
+    const providerVisible = await authedPage
+      .getByText(/discord|github|google|oauth|provider/i)
+      .first()
+      .isVisible({ timeout: 5000 })
+      .catch(() => false);
+    if (!providerVisible) {
+      await expect(
+        authedPage.getByText(/no.*(provider|connection|configured)|none\s*(available|configured)/i).first()
+      ).toBeVisible({ timeout: 5000 });
+    }
   });
 });

e2e/integration/signalr.spec.ts

@@ -49,12 +49,9 @@ test.describe('SignalR connection lifecycle', () => {
     await authedPage.waitForLoadState('networkidle');
     await authedPage.waitForTimeout(3000);
 
-    // On an authenticated session the frontend should attempt to establish a
-    // SignalR connection (negotiate HTTP + WebSocket upgrade).
-    // If the backend is not running this will fail gracefully — we just check
-    // that the attempt was made.
-    expect(wsRequests.length).toBeGreaterThanOrEqual(0); // always passes
-    // The real assertion: no crash occurred (covered by pageerror listener above)
+    // On an authenticated session the frontend must attempt to establish a
+    // SignalR connection — assert at least one negotiate/WebSocket request fired.
+    expect(wsRequests.length).toBeGreaterThan(0);
   });
 });
 

vite.config.ts

@@ -290,7 +290,7 @@ export default defineConfig(async ({ command, mode, isPreview }) => {
           extends: true,
           // Resolve Svelte to its browser (client) build so that `mount` and
           // other client-only APIs are available in the jsdom test environment.
-          resolve: { conditions: ['browser', 'module', 'svelte', 'development|production'] },
+          resolve: { conditions: ['browser', 'module', 'svelte', 'development', 'production'] },
           test: {
             name: 'components',
             environment: 'jsdom',