Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a full integration-testing scaffold (Playwright + Docker-backed backend) and expands the unit/component test setup (Vitest projects + Testing Library) to improve confidence in both frontend state modules and end-to-end user journeys.
Changes:
- Added Playwright “integration” test suite that boots a local docker-compose backend and runs against a Vite integration mode.
- Split Vitest into unit vs jsdom/component projects and added a large set of new unit/component tests across state, API helpers, and SignalR handlers.
- Introduced small runtime fixes (auth state reset when unauthenticated, safer navigation state tracking, empty-state UI) plus basic security headers via
hooks.server.ts.
Reviewed changes
Copilot reviewed 59 out of 60 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.setup.ts | Adds jest-dom matchers for Vitest (jsdom/component tests). |
| vite.config.ts | Adds integration-mode env loading, Vite proxying for /1 & /2, Vitest multi-project setup, and integration TLS behavior. |
| src/routes/+error.svelte | Makes afterNavigate handling null-safe with optional chaining. |
| src/routes/(app)/shares/user/outgoing/+page.svelte | Adds outgoing-shares empty state UI. |
| src/routes/(app)/settings/api-tokens/+page.svelte | Fixes token creation state update to use reassignment (reactivity-friendly). |
| src/lib/state/user-state.test.svelte.ts | Adds tests for user state behavior and refreshSelf paths. |
| src/lib/state/user-shares-state.test.svelte.ts | Adds tests for shares state refresh functions and error handling. |
| src/lib/state/shared-hubs-state.test.svelte.ts | Adds tests for shared hubs state initialization and refresh. |
| src/lib/state/live-control-state.test.svelte.ts | Adds extensive tests for live-control state, WebSocket handling, and helpers. |
| src/lib/state/hubs-state.test.svelte.ts | Adds tests for hubs state and refreshOwnHubs behavior. |
| src/lib/state/color-scheme-state.test.svelte.ts | Adds jsdom tests for theme handling and DarkReader detection. |
| src/lib/state/breadcrumbs-state.test.svelte.ts | Adds tests for breadcrumb registration lifecycle via fixture component. |
| src/lib/state/backend-metadata-state.test.svelte.ts | Adds tests for backend metadata initialization and error cases. |
| src/lib/state/fixtures/BreadcrumbRegistrar.svelte | Test fixture component for breadcrumb registration. |
| src/lib/signalr/handlers/OtaRollback.test.ts | Adds tests for OTA rollback SignalR handler effects/toasts. |
| src/lib/signalr/handlers/OtaInstallProgress.test.ts | Adds tests for OTA progress handler updates and validation. |
| src/lib/signalr/handlers/Log.test.ts | Adds tests for SignalR log validation and listener dispatch behavior. |
| src/lib/signalr/handlers/DeviceUpdate.test.ts | Adds tests for device update handler routing and validation. |
| src/lib/signalr/handlers/DeviceStatus.test.ts | Adds tests for device status handler behavior and validation. |
| src/lib/components/ui/data-table/mergeObjects.test.ts | Adds tests for mergeObjects proxy/override behavior. |
| src/lib/components/dialog-manager/dialog-store.test.svelte.ts | Adds tests for dialog store creation/removal and confirm/alert flows. |
| src/lib/api/pwnedPasswords.test.ts | Adds tests for HIBP range lookup parsing and error handling. |
| src/lib/api/firmwareCDN.test.ts | Adds tests for firmware CDN fetching/parsing and hash verification. |
| src/hooks.server.ts | Adds security headers (nosniff, SAMEORIGIN) globally. |
| src/hooks.client.ts | Resets userState when backend says the user is unauthenticated. |
| scripts/dev-integration.mjs | Starts docker-compose integration stack, waits for backend, then launches Vite integration mode. |
| README.md | Adds CI badge entries for the new integration workflow. |
| pnpm-lock.yaml | Adds Testing Library + jsdom dependencies and updates Vitest peer graph. |
| playwright.e2e.config.ts | Adds separate “full E2E” Playwright config targeting a remote environment. |
| playwright.config.ts | Replaces default config with integration-focused Playwright setup + docker-backed webServer. |
| package.json | Adds dev:integration, splits test:integration vs test:e2e, updates test script. |
| eslint.config.js | Disables no-explicit-any for test files. |
| e2e/integration/smoke.spec.ts | Adds baseline smoke coverage for integration harness + fixtures. |
| e2e/integration/signalr.spec.ts | Adds SignalR lifecycle checks (no errors) and request observation. |
| e2e/integration/shockers.spec.ts | Adds basic route render/empty-state checks for shockers/hubs pages. |
| e2e/integration/shares.spec.ts | Adds basic route checks for share pages + non-500 on fake share link. |
| e2e/integration/sessions-connections.spec.ts | Adds basic checks for sessions and connections pages. |
| e2e/integration/public-pages.spec.ts | Adds checks for public pages and auth redirects for protected routes. |
| e2e/integration/oauth-and-password-reset.spec.ts | Adds basic UI checks for OAuth buttons and password reset page behavior. |
| e2e/integration/live-control.spec.ts | Adds basic route checks for live-control related pages and fake IDs. |
| e2e/integration/lib/test-fixtures.ts | Adds API-driven user lifecycle + cookie injection fixtures for integration tests. |
| e2e/integration/lib/global-teardown.ts | Adds CI-only docker-compose shutdown for integration runs. |
| e2e/integration/lib/global-setup.ts | Placeholder globalSetup (docker started by webServer script). |
| e2e/integration/lib/env.ts | Centralizes integration test env defaults. |
| e2e/integration/lib/api-client.ts | Adds API client helpers for signup/activate/login/delete/logout via backend + MailPit. |
| e2e/integration/cross-cutting.spec.ts | Adds cross-cutting checks (headers, 404 behavior, navigation, responsiveness). |
| e2e/integration/auth.spec.ts | Adds integration-level tests for login/signup/logout flows. |
| e2e/integration/api-tokens.spec.ts | Adds integration tests for token creation/listing/deletion via UI. |
| e2e/integration/admin.spec.ts | Adds non-admin coverage ensuring admin routes don’t 500 and handle denial. |
| e2e/integration/account-settings.spec.ts | Adds basic settings/profile/session UI checks. |
| e2e/indexpage.test.ts | Removes the old single Playwright test in favor of the new structure. |
| e2e/e2e/signup-verify.spec.ts | Adds full E2E signup/verify/login tests (MailPit-gated). |
| e2e/e2e/login-logout.spec.ts | Adds full E2E UI-level login/logout structure tests. |
| e2e/e2e/lib/test-fixtures.ts | Adds full E2E fixtures including Turnstile bypass and teardown deletion. |
| e2e/e2e/lib/mailpit.ts | Adds MailPit API helpers for polling emails and extracting links. |
| e2e/e2e/lib/env.ts | Adds full E2E env defaults (next.openshock.dev, optional MailPit). |
| e2e/e2e/lib/api-client.ts | Minimal API client for full E2E teardown/logout. |
| docker-compose.integration.yml | Adds integration backend stack (postgres/redis/mailpit/api) for local+CI. |
| .github/workflows/ci-integration.yml | Adds CI job to run integration tests with Playwright + cached browsers. |
| .env.integration | Adds Vite integration-mode env values (proxy target + site URLs). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.