Skip to content

Color Grade effect (Color Correction, Scopes, Grading)#1062

Open
jonoomph wants to merge 10 commits intodevelopfrom
color-grade
Open

Color Grade effect (Color Correction, Scopes, Grading)#1062
jonoomph wants to merge 10 commits intodevelopfrom
color-grade

Conversation

@jonoomph
Copy link
Copy Markdown
Member

@jonoomph jonoomph commented Apr 25, 2026

Related to an entire color UI workflow: OpenShot/openshot-qt#6016

jonoomph added 10 commits April 17, 2026 22:47
…mize its curve processing using per-frame LUTs for faster OMP rendering, expand backend ColorGrade

  test coverage for disable/alpha behavior, and include the new ShadowGlow effect sources
…actical waveform dataset the UI needs:

  - video.histogram.luma
  - video.histogram.red
  - video.histogram.green
  - video.histogram.blue
  - video.waveform.luma
  - video.waveform.red
  - video.waveform.green
  - video.waveform.blue
… Json handling is now lazy, only when needed, and new swig getters and available for faster access to analysis data for image and audio data.
…rter more consise way of saying the same thing (without text wrapping in the UI)
…emultiplied format, and adding unit test to verify.
… R,G,B, and All using a new AnmiatedCurve class which supports a variable # of nodes for adjusting colors. Also, keyframable color wheels, amount sliders, and luma sliders. So now our color grade effect is fully controllable and keyframable. Including new unit tests for color grade effect.
…ily render high performance vectorscope density planes. Updated unit tests, and did some light refactoring to ensure performance.
@jonoomph jonoomph changed the title Color Grade effect (Color Correct and Color Grading) Color Grade effect (Color Correction, Scopes, Grading) Apr 25, 2026
@jonoomph
Copy link
Copy Markdown
Member Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

❌ Patch coverage is 91.45299% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.39%. Comparing base (a36dcb5) to head (81aa6d9).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/FrameScope.cpp 86.25% 51 Missing ⚠️
src/effects/ColorGrade.cpp 92.88% 20 Missing ⚠️
src/FrameScope.h 60.46% 17 Missing ⚠️
src/AnimatedCurve.cpp 87.20% 16 Missing ⚠️
src/EffectInfo.cpp 33.33% 2 Missing ⚠️
src/effects/ColorGrade.h 0.00% 2 Missing ⚠️
src/EffectBase.cpp 50.00% 1 Missing ⚠️
tests/FrameScope.cpp 99.40% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1062      +/-   ##
===========================================
+ Coverage    65.83%   67.39%   +1.55%     
===========================================
  Files          214      229      +15     
  Lines        24232    26051    +1819     
===========================================
+ Hits         15953    17556    +1603     
- Misses        8279     8495     +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant