Conversation
…ile-scaled grain rendering, bindings, registration, and unit tests. Also update Analog Tape artifact scaling so preview and export sizes stay visually consistent.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1063 +/- ##
===========================================
+ Coverage 66.15% 68.34% +2.18%
===========================================
Files 220 232 +12
Lines 24756 26731 +1975
===========================================
+ Hits 16377 18268 +1891
- Misses 8379 8463 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
…ation_x/y did not correctly calculate the offscreen coordinates. This will have backwards compatibility implications, since old projects that combine custom location_x/y + CROP scale mode will calculate position differently now. Added tests: - location_x/y = -1/+1 offscreen behavior for all scale enums and multiple scale_x/y combinations. - all 9 gravity anchors when location_x/y = 0, including sub-100% and non-uniform scale. - Crop-specific intermediate location behavior so the original bug stays covered.
# Conflicts: # src/CMakeLists.txt # src/EffectInfo.cpp # src/Effects.h # tests/CMakeLists.txt
- Cache y-pre-lerped bilinear columns for soft and clump noise, refreshing only when the x-cell index changes (~every 7 px for soft, ~every 9 px for clump at defaults). Fine grain hash is similarly cached per cell. This cuts amortized hash_coords + mix32 calls from ~56 to ~9 per pixel in the fully-featured case. - hoist all y-dependent values out of the x-loop; replace std::round in clampByte; extract salt magic numbers to named constants; move alpha_percent to the write-back branch where it's actually needed; collapse the color-apply branch to use_color_variation directly.
|
Merge conflicts have been detected on this PR, please resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Film Grain effect adds a gentle moving texture to your video, similar to the tiny speckles you see in real film photography. This can make very clean digital footage feel warmer, more natural, or more cinematic. It can also help blend mixed footage together, especially when one clip looks too sharp or too smooth compared to the rest of your project.