Rename macOS hardware decoder label to "Apple VideoToolbox"#6003
Open
geekrebel wants to merge 1 commit into
Open
Rename macOS hardware decoder label to "Apple VideoToolbox"#6003geekrebel wants to merge 1 commit into
geekrebel wants to merge 1 commit into
Conversation
…oToolbox" so it matches the naming convention of the other hardware acceleration entries (e.g. "Linux VA-API", "Nvidia NVDEC", "Intel QSV"). The underlying decoder integer value (5) is unchanged, so existing user preferences continue to resolve to the same VideoToolbox path in libopenshot. The short label shown on the About dialog's performance line is also updated to "VideoToolbox". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS entry in the Hardware Decoder Mode dropdown is labelled simply
"MacOS", which is inconsistent with the other platform labels ("Linux VA-API",
"Nvidia NVDEC", "Windows D3D11", "Intel QSV", ...). This renames it to
"Apple VideoToolbox" and updates the two places that match on the English
label (preferences.py icon map, about.py short performance-line label).
The underlying
hw-decoderinteger (5) is unchanged, so existing user settingscontinue to resolve to the same VideoToolbox path in libopenshot.
Scope is intentionally small to stay easy to review; this is the first in a
planned series of small Apple Silicon PRs (next: arch-aware DMG naming in
installer/build_server.py, and replacing the hard-coded /usr/local/Cellar
Python 3.7 path in installer/build-mac-dmg.sh).
Note for follow-up: the icon-matching block at preferences.py:448+ has a
latent bug - it checks
i == <int>as a fallback, but no hw-decoder valuein _default.settings actually carries an "icon" field, so icons only resolve
by English label. Worth a separate PR to add "icon" fields to the settings
entries.