Film Grain Effect (35mm, 16mm, super 8, high ISO)#6017
Merged
Conversation
- Add Film Grain preset helper with editable preset values - Add clip context menu presets: No Film Grain, 35mm Fine, 35mm Classic, 35mm Gritty, 16mm Classic, Super 8, High ISO - Add timeline helper tests for applying, replacing, and removing Film Grain effects - Add preset unit tests and Film Grain effect icons - Assign Film Grain a timeline color - Fix integer property dragging for Seed and remove noisy drag debug logging
Member
Author
- Group Rotate, Crop, and Layout under a new Transform submenu with a "No Transform" reset (single undo step) - Rename Color → Look; nest Color presets and Film Grain as parallel submenus with a unified "Reset Look" - Rename Volume → Audio; nest volume controls under Volume; move Separate Audio (renamed to Separate) and waveform toggle inside - Rename Time → Speed, Fast/Slow → Speed Up/Slow Down, "Reset Time" → Reset - Rename Animate → Motion - Remove standalone Display submenu; waveform toggle moves into Audio (audio-only clips) - Add view-waveform.svg and view-waveform-flat.svg icons - Remove stray debug print() statement
- Hiding options that are audio-only, when no audio track exists - Hiding options that are video-only, when no video track or clip::waveform exists - Re-organization Fade In/Out menu to be simpler, and to clobber previous fade in/out options so they no longer collide (using this menu multiple times is fine now). - Fade In/Out now fades both audio and video (if both exist), or only audio (if audio only), or only video (if only video). - Audio & Volume menu behaves similarly to Fade In/Out, works much better, and simpler. Only appears when audio tracks are present. - Analyze Audio (to show scope for audio levels) is always present regardless of audio track - Fixed Color options to be useful anytime a video track (or waveform true) on a clip
…ack mode to edit mode. Only user updates to transform, properties, curve editor, and color wheels should switch to edit mode (and disable video playback caching). Normal updates, like moving a clip, adding a clip should not stop video playback caching. AND... if playback is active while a property/transform is edited, do not disable caching.
- Replace old scale-zoom / edge-to-edge Motion menu with fully restructured In / Out / Emphasis / Camera / Credits submenus - Apply presets relative to clip's current transform state (multiplicative for scale/alpha, additive for location/rotation/shear) - Refactor VideoWidget._clip_display_rect → _clip_location_geometry + _location_offset / _location_value_from_offset for correct drag-to-normalized-coordinate conversion; add SCALE_NONE support - Add tests for wipe mask contrast, Ken Burns keyframes, and location offset round-trip
… inside clip/effect/transition properties. That covers the new ColorGrade wheel and curve editor structures, while preserving the existing special time behavior where both X and Y frame values are scaled. - Also added new unit tests to validate change
- Add pure camera motion helper for crop-aware zoom, pan, and zoom+pan keyframes - Compute safe pan ranges from project and source aspect ratios to avoid black bars - Use natural crop room for wide/tall media and only add extra zoom when needed - Add Auto Direction support for Pan and Zoom & Pan presets - Reorganize Camera menu into Zoom, Pan, and Zoom & Pan groups - Add directional Zoom & Pan presets with translatable labels - Add unit coverage for smart camera framing and update timeline integration tests
- Recursively scale nested Points keyframes during timeline retime operations - Cover ColorGrade color wheel and curve editor keyframes in retime regression tests - Refresh the Color Wheels dock from current model data after external edits - Reset the dock to neutral disabled wheels when no ColorGrade effect is selected or bound - Render color wheel controls and Amount/Luma sliders in muted gray while disabled
- Increase Bounce In/Out and Emphasis bounce offsets so rebounds are visibly frame-relative - Fix Emphasis presets to apply at the playhead by converting timeline frames to clip-local frames - Alphabetize Motion > In, Out, and Emphasis preset menus and submenu entries - Add regression coverage for bounce keyframe values and playhead-based Emphasis placement
- Add dedicated insert/remove support for Color Grade curve and wheel properties - Prevent Properties table Insert Keyframe from replacing rich wheel payloads - Remove nested Color Grade keyframes without clearing unrelated frames - Rebind open Curve Editor callbacks after Properties model refreshes - Make newly added curve nodes interpolate linearly across animated frames - Enable Color Wheels dock Remove Keyframe between keyframes - Darken disabled Color Wheels dock styling using theme-adaptive palette colors - Add regression tests for nested Color Grade keyframe insert/remove and curve interpolation
- Group Look options into Color, Film, Focus, and Lighting - Add Look presets for Analog Tape, Sharpen, Blur, Shadow, and Glow - Preserve Film Grain presets under the new Film submenu - Add Reset Look support for Color Grade, Film Grain, and Look-managed effects - Tag Look-created generic effects with ui-menu metadata to avoid clobbering manual or motion effects (ui-menu) - Handle animated RGBA color properties for Shadow and Glow presets
…lity (renaming/reoganized menus).
…ow, Shadow, and Color Grade (updating menu names, and making some small improvements)
…eatures to the introduction, and including common search phrases, new chromakey instructions, and more. Updating copyright year on all *.rst files. Removing some old export presets that are SD and no longer relevant. Also adding many new export presets for modern, popular social networks, such as Snapchat, Facebook, Instagram, TikTok, and LinkedIn, and renaming some -HD suffixes that are not used anymore.
…nized and renamed), and fixing a syntax error in the *.rst export file
- Promote Simple, Color, and Advanced View actions to the top-level View menu - Move Toolbar and Fullscreen into a new Window submenu - Keep Docks as a top-level View submenu, excluding Tutorial and scope docks - Add a top-level Scopes submenu with scope dock toggles and Show All Scopes - Rename Freeze/Un-Freeze View to Lock/Unlock Docks - Move Lock/Unlock Docks and Show All Docks into the Docks menu - Make Show All Docks skip the Tutorial dock - Add middle-click-to-close support for dock title bars and tabified dock tabs - Fix Cosmic Dusk checked menu item alignment
…audio or not. Also, hide the "Audio" sub-menu in the clip menu for image-only files (i.e. no audio data)
- Add dynamic Show All / Close All actions for Docks and Scopes - Add Lock Scopes / Unlock Scopes with persisted scopes_frozen state - Keep locked dock/scope menu toggles clickable while hiding dock chrome controls - Apply dock/scope lock state consistently when docks are added or shown - Include Color Wheels in Docks bulk actions and lock handling - Keep live color grade edit mode from re-enabling preview caching until seek/play - Add regression tests for dock lock-state sync and live-property cache behavior
…serting any keyframes. Now sure if this was a regression or an existing bug.
…never really fully baked: locking/unlocking docks (legacy feature inherited from original Qt implementation). Show / Hide all docks options (we already have Views that are more useful for hiding/showing and positioning docks). - Removed Dock/Scope locking behavior and saved lock state handling from src/windows/main_window.py. - Removed Lock Docks, Unlock Docks, and Show All Docks actions from src/windows/ui/main-window.ui. - Removed related default shortcut/settings entries from src/settings/_default.settings. - Kept Show All Scopes / Close All Scopes as conditional actions under Scopes. - Updated focused tests in src/tests/test_main_window.py. - Removed obsolete shortcuts from doc/main_window.rst.
…save the current view, choose custom views, or update/delete custom views. It's purposely kept simple but very easy to use for customizing OpenShot for specific user work-flows. Also updated docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to OpenShot/libopenshot#1063