Skip to content

Align custom traffic action with osc #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefancyliax merged 5 commits into from
Sep 7, 2021
Merged

Align custom traffic action with osc #523

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7acdde
Add a type field for custom traffic actions
caspar-ai May 28, 2021
e3452d3
Use a more specific field name
caspar-ai May 28, 2021
06ce8db
Add more detail to documentation
caspar-ai Jun 9, 2021
6aaadca
Apply suggestions from code review
caspar-ai Aug 10, 2021
1b6fa8c
Merge branch 'master' into feature/align-custom-traffic-action-with-osc
Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions osi_trafficcommand.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,10 @@ message TrafficAction
// The custom command given to the traffic participant.
//
optional string command = 2;

// The type of the custom command given to the traffic participant.
//
optional string command_type = 3;
Comment on lines 490 to +504

@kmeids kmeids Jun 9, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output CCB 09.06.2021:

  1. Please provide more documentation on the "command" and "command_type" messages, stating the difference between them and how/in which situations should it be used.
  2. As a "note", please mention for both commands that they are mapped to OSC.

@caspar-ai caspar-ai Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmeids I have updated the comments as suggested.

Does that look OK to you?

}

// \brief Longitudinal Distance Action
Expand Down