Skip to content

Commit 44f92d2

Browse files
author
Stefan Cyliax
authored
Merge pull request #78 from OpenSimulationInterface/documentation/native-speaker-review
docs: minor corrections according to native speaker review
2 parents ee71982 + af5389a commit 44f92d2

5 files changed

Lines changed: 13 additions & 13 deletions

File tree

doc/misc/example.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
= Example: Simple sensor model FMU
22

3-
Then following example shows the content of a `modelDescription.xml` file that satisfies the requirements of OSMP.
3+
The following example shows the content of a `modelDescription.xml` file that satisfies OSMP requirements.
44
The example describes a sensor model FMU with one input, one output, and no additional features:
55

66
[source,xml]

doc/setup/build_install_example.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Demonstrates a simple C network proxy that can send and receive OSI data via TCP
2626
git clone https://github.com/OpenSimulationInterface/osi-sensor-model-packaging.git
2727
----
2828
+
29-
. Change into the OSMP repository.
29+
. Switch to the OSMP repository.
3030
+
3131
[source]
3232
----
@@ -40,7 +40,7 @@ cd osi-sensor-model-packaging
4040
git submodule update --init
4141
----
4242
+
43-
. Change into the `examples/` directory.
43+
. Switch to the `examples/` directory.
4444
+
4545
[source]
4646
----
@@ -54,7 +54,7 @@ cd examples
5454
mkdir -p build
5555
----
5656
+
57-
. Change into the `build/` directory.
57+
. Switch to the `build/` directory.
5858
+
5959
[source]
6060
----

doc/spec/binary_variables.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
= Binary variables
22

33
FMI 2.0 does not directly support the efficient exchange of arbitrary binary data between FMUs.
4-
OSMP, therefore, introduces the concept of notional binary variables, which are mapped to actual integer variables for use with FMI 2.0.
4+
OSMP therefore introduces the concept of notional binary variables that are mapped to actual integer variables for use with FMI 2.0.
55
Future FMI versions will directly support binary variables compatible with this concept.
66

77
A notional binary variable named `<prefix>` is defined using the following conventions:
@@ -14,9 +14,9 @@ This restriction ensures that there is no conflict between notional binary varia
1414
For each notional binary variable, three actual FMU integer variables shall be defined:
1515

1616
`<prefix>.base.lo`::
17-
Lower, meaning least significant, 32-bit address part of the binary data buffer to be passed into or out of the model, cast into a signed 32-bit integer without changing the bit values.
17+
Lower, meaning the least significant, 32-bit address part of the binary data buffer to be passed into or out of the model, cast into a signed 32-bit integer without changing the bit values.
1818
`<prefix>.base.hi`::
19-
Higher, meaning most significant, 32-bit address part of the binary data buffer to be passed into or out of the model, cast into a signed 32-bit integer without changing the bit values.
19+
Higher, meaning the most significant, 32-bit address part of the binary data buffer to be passed into or out of the model, cast into a signed 32-bit integer without changing the bit values.
2020
Note that this variable is only used for 64-bit platforms.
2121
For 32-bit platforms, it shall still be present but will always be 0 to support FMUs with 32-bit and 64-bit implementations.
2222
`<prefix>.size`::
@@ -40,7 +40,7 @@ The three actual variables shall contain an annotation of the following form in
4040

4141
`<prefix>` is the prefix as defined above, and `@role` is either `base.lo`, `base.hi`, or `size`, depending on the variable.
4242

43-
It is an error if there is not exactly one variable of each role for the same name.
43+
There is an error if there is not exactly one variable of each role for the same name.
4444

4545
The MIME type given in `@mime-type` shall be a valid MIME type specification.
4646

doc/spec/model_types.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ They may also consume `osi3::TrafficCommand` as input to allow control by a scen
2424
All models may also consume a global `osi3::GroundTruth` parameter during initialization.
2525

2626
Complex models may combine various aspects of the above model types.
27-
Configuration and setup of such FMUs require manual intervention.
27+
Manual intervention is needed to configure and set up these FMUs.

doc/spec/traffic_command_inputs.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
= Traffic command inputs
22

33
Traffic command inputs are present in traffic participant models.
4-
This allows control of the traffic participant behavior by scenario engines.
4+
This makes it possible to control of the traffic participant behavior using scenario engines.
55

66
**Prefix**
77

@@ -14,9 +14,9 @@ Traffic command inputs shall be named with the following prefix:
1414

1515
**Rules**
1616

17-
* If only one traffic command input is configured, the prefix shall only be `OSMPTrafficCommandIn`.
18-
* If more than one traffic command input is configured, the prefix shall be extended by an array index designator, for example `OSMPTrafficCommandIn[1]` and `OSMPTrafficCommandIn[2]`.
19-
* Array indices shall start at 1 and shall be consecutive.
17+
* If only one traffic command input is configured, the prefix shall only be `OSMPTrafficCommandIn`.
18+
* If more than one traffic command input is configured, the prefix shall be extended by an array index designator, for example `OSMPTrafficCommandIn[1]` and `OSMPTrafficCommandIn[2]`.
19+
* Array indices shall start at 1 and shall be consecutive.
2020
* Each traffic command input shall be defined as a notional discrete binary input variable with `@causality="input"` and `@variability="discrete"`.
2121
* The MIME type of the variable shall specify the `type="TrafficCommand"` as part of the MIME type parameters.
2222
* Traffic commands shall be encoded as `osi3::TrafficCommand`.

0 commit comments

Comments
 (0)