Skip to content

Commit 68d95f3

Browse files
Copilotpmai
andauthored
Simplify to args.config_path is None, remove -d flag, update README
Agent-Logs-Url: https://github.com/OpenSimulationInterface/qc-osi-trace/sessions/913b681d-c5fd-413a-9cbe-52253a4d5a3e Co-authored-by: pmai <91502+pmai@users.noreply.github.com>
1 parent a890a66 commit 68d95f3

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,14 @@ from qc_ositrace.checks.deserialization import deserialization_checker
5050
```bash
5151
qc_ositrace --help
5252

53-
usage: QC OSI Trace Checker [-h] (-d | -c CONFIG_PATH) [-i INPUT_FILE] [--osiTopic OSITOPIC] [--osiType OSITYPE]
53+
usage: QC OSI Trace Checker [-h] [-c CONFIG_PATH] [-i INPUT_FILE] [--osiTopic OSITOPIC] [--osiType OSITYPE]
5454
[--osiVersion OSIVERSION] [--osiRulesFile OSIRULESFILE] [-r RESULT_FILE]
5555
[--output_config OUTPUT_CONFIG]
5656

5757
ASAM QC checker bundle for checking the validity of OSI Trace (.osi/.mcap) files.
5858

5959
options:
6060
-h, --help show this help message and exit
61-
-d, --default_config
6261
-c, --config_path CONFIG_PATH
6362
-i, --input_file INPUT_FILE
6463
Path to the input OSI Trace file.
@@ -77,7 +76,7 @@ options:
7776
Example checking a simple SensorData trace file against version 3.7.0 rules using default configuration:
7877

7978
```bash
80-
qc_ositrace -d -r results.xqar --osiType SensorData --osiVersion 3.7.0 -i 20210818T150542Z_sd_370_300_1523_example_sensordata_trace.osi
79+
qc_ositrace -r results.xqar --osiType SensorData --osiVersion 3.7.0 -i 20210818T150542Z_sd_370_300_1523_example_sensordata_trace.osi
8180
```
8281

8382
### Example output
@@ -144,15 +143,14 @@ It is also possible to execute the qc_ositrace application using Poetry:
144143
```bash
145144
poetry run qc_ositrace --help
146145

147-
usage: QC OSI Trace Checker [-h] (-d | -c CONFIG_PATH) [-i INPUT_FILE] [--osiTopic OSITOPIC] [--osiType OSITYPE]
146+
usage: QC OSI Trace Checker [-h] [-c CONFIG_PATH] [-i INPUT_FILE] [--osiTopic OSITOPIC] [--osiType OSITYPE]
148147
[--osiVersion OSIVERSION] [--osiRulesFile OSIRULESFILE] [-r RESULT_FILE]
149148
[--output_config OUTPUT_CONFIG]
150149

151150
ASAM QC checker bundle for checking the validity of OSI Trace (.osi/.mcap) files.
152151

153152
options:
154153
-h, --help show this help message and exit
155-
-d, --default_config
156154
-c, --config_path CONFIG_PATH
157155
-i, --input_file INPUT_FILE
158156
Path to the input OSI Trace file.

qc_ositrace/main.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ def args_entrypoint() -> argparse.Namespace:
1818
description="ASAM QC checker bundle for checking the validity of OSI Trace (.osi/.mcap) files.",
1919
)
2020

21-
group = parser.add_mutually_exclusive_group(required=False)
22-
group.add_argument("-d", "--default_config", action="store_true")
23-
group.add_argument("-c", "--config_path")
21+
parser.add_argument("-c", "--config_path")
2422

2523
parser.add_argument(
2624
"-i",
@@ -95,7 +93,7 @@ def main():
9593
logging.info("Initializing checks")
9694

9795
config = Configuration()
98-
if args.default_config or args.config_path is None:
96+
if args.config_path is None:
9997
logging.info("Using default configuration")
10098
config.register_checker_bundle(checker_bundle_name=constants.BUNDLE_NAME)
10199
else:

0 commit comments

Comments
 (0)