Implement issue #239: Inspector Graph: better component titles#254
Implement issue #239: Inspector Graph: better component titles#254LabordePierre wants to merge 1 commit intomainfrom
Conversation
YannLeGoff
left a comment
YannLeGoff
left a comment
There was a problem hiding this comment.
It is complicated for me to understand wich label is the type, wich is the implementation and wich is the name.
What do you think of the picture ?
|
|
||
| "don't display the default name to have better visual identification of named components" | ||
| componentNameText := self componentName = (MolUtils defaultComponentName) | ||
| ifTrue:[ '' ] |
There was a problem hiding this comment.
I do believe this could cause trouble when trying to debug a component with a default name.
There was a problem hiding this comment.
You can access this ionformation with hover, and i am not sure how often you will have to debug a component named default ?
There was a problem hiding this comment.
The idea is to have a better distinction between a component with a custom name and a component with the default name (not specified by the user). I understand the need to display default, can we use a different font style when the component is named? i.e. blue italic.
Replace Impl: with Class: |
@LANDAISB any opinion? We discuss on that before the commit and I prefer not add prefix to have lighter display. |
|
I prefer "Impl" instead of "Class" |
|
I prefer to add default name (ie. always display the key of component), not sure it's necessary to have a different look than a choosed name. |
3 participants
No description provided.