Fix contributor entry for Logicrithm#950
Conversation
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this pull request is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch.
We would suggest that you close this pull request, create a new branch, implement your changes, and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- package-lock.json
There was a problem hiding this comment.
Pull request overview
This PR aims to add the GitHub user Logicrithm as a contributor using the repository’s all-contributors setup, but it also changes the contributor tooling dependency + lockfile in ways that are unrelated and potentially harmful.
Changes:
- Adds a new contributor entry for
Logicrithmin.all-contributorsrc. - Downgrades
all-contributors-clifrom^6.xto^3.1.1. - Regenerates
package-lock.json, including a lockfile format bump to v3 and older/deprecated transitive dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Downgrades all-contributors-cli to ^3.1.1. |
| package-lock.json | Regenerated lockfile with lockfileVersion: 3 and dependencies aligned to the downgraded CLI. |
| .all-contributorsrc | Adds the Logicrithm contributor entry (but README isn’t updated in this PR). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "license": "ISC", | ||
| "devDependencies": { | ||
| "all-contributors-cli": "^6.25.0" | ||
| "all-contributors-cli": "^3.1.1" |
There was a problem hiding this comment.
The PR downgrades all-contributors-cli to ^3.1.1, which is a major regression from the version already used in this repo (e.g., pnpm-lock.yaml pins ^6.25.0). This will likely break contributor tooling consistency across package managers and reintroduce older transitive deps. Please revert to the repo’s current all-contributors-cli version and regenerate lockfiles with a single package manager to keep them in sync.
| "all-contributors-cli": "^3.1.1" | |
| "all-contributors-cli": "^6.25.0" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hey @Logicrithm, However, we will close this PR with following reasons:
If you still want to contribute:
Let me know if you have questions or need help! |
Description
Added myself as a contributor following the contribution guidelines.
What type of PR is this?
Contributors Checklist
npm run contributors:generatedue to compatibility issues, so I added my entry manually.Added to documentation?