Skip to content

Fix contributor entry for Logicrithm#950

Closed
Logicrithm wants to merge 7 commits into
OpenSource-Communities:mainfrom
Logicrithm:main
Closed

Fix contributor entry for Logicrithm#950
Logicrithm wants to merge 7 commits into
OpenSource-Communities:mainfrom
Logicrithm:main

Conversation

@Logicrithm
Copy link
Copy Markdown

Description

Added myself as a contributor following the contribution guidelines.

What type of PR is this?

  • 🤝 Add a contributor

Contributors Checklist

  • ✅ I've read through the Getting Started section
  • ❌ I was unable to run npm run contributors:generate due to compatibility issues, so I added my entry manually.

Added to documentation?

  • 📜 README.md

@Logicrithm Logicrithm requested a review from BekahHW as a code owner April 23, 2026 07:00
Copilot AI review requested due to automatic review settings April 23, 2026 07:00
@Logicrithm Logicrithm requested a review from adiati98 as a code owner April 23, 2026 07:00
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this pull request is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch.
We would suggest that you close this pull request, create a new branch, implement your changes, and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add the GitHub user Logicrithm as a contributor using the repository’s all-contributors setup, but it also changes the contributor tooling dependency + lockfile in ways that are unrelated and potentially harmful.

Changes:

  • Adds a new contributor entry for Logicrithm in .all-contributorsrc.
  • Downgrades all-contributors-cli from ^6.x to ^3.1.1.
  • Regenerates package-lock.json, including a lockfile format bump to v3 and older/deprecated transitive dependencies.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
package.json Downgrades all-contributors-cli to ^3.1.1.
package-lock.json Regenerated lockfile with lockfileVersion: 3 and dependencies aligned to the downgraded CLI.
.all-contributorsrc Adds the Logicrithm contributor entry (but README isn’t updated in this PR).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
"license": "ISC",
"devDependencies": {
"all-contributors-cli": "^6.25.0"
"all-contributors-cli": "^3.1.1"
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR downgrades all-contributors-cli to ^3.1.1, which is a major regression from the version already used in this repo (e.g., pnpm-lock.yaml pins ^6.25.0). This will likely break contributor tooling consistency across package managers and reintroduce older transitive deps. Please revert to the repo’s current all-contributors-cli version and regenerate lockfiles with a single package manager to keep them in sync.

Suggested change
"all-contributors-cli": "^3.1.1"
"all-contributors-cli": "^6.25.0"

Copilot uses AI. Check for mistakes.
Comment thread .all-contributorsrc
Comment thread .all-contributorsrc Outdated
Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the changes

Logicrithm and others added 2 commits April 23, 2026 13:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h

@adiati98
Copy link
Copy Markdown
Collaborator

adiati98 commented Apr 23, 2026

Hey @Logicrithm,
Thank you for taking on this! We appreciate your contribution. ✨

However, we will close this PR with following reasons:

  • You made changes directly on the main branch, and we don't allow that. Please see this bot warning.
  • You altered the package-lock.json. We don't want to make any changes to this file.

If you still want to contribute:

  • Create a new branch and work on this branch, then create a new PR.

  • Running the commands to add and generate your profile is the recommended way to contribute. I see that you mentioned:

    I was unable to run npm run contributors:generate due to compatibility issues, so I added my entry manually.

    I guess that's why you donwgraded the all-contributors-cli? If you cloned this repo and ran npm ci, I think you won't have this problem. If it still persists and you need to use a version that's compatible, when committing your changes, don't use git add . or git commit -am. You want to only commit and push the changes in the .all-contributorsrc and README.md files.

Let me know if you have questions or need help!

@adiati98 adiati98 closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants