feat: add @Logicrithm as a contributor#951
Conversation
|
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @Logicrithm! You're almost to the end of the course! |
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this pull request is meant to address.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- package-lock.json
There was a problem hiding this comment.
Pull request overview
This PR aims to add @Logicrithm as an all-contributors entry in the repository documentation/config, but it also changes the contributor tooling dependency and regenerates the npm lockfile.
Changes:
- Add
Logicrithmto the all-contributors list inREADME.md. - Add
Logicrithmto.all-contributorsrc. - Downgrade
all-contributors-cliand updatepackage-lock.json(includinglockfileVersionchange).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Downgrades all-contributors-cli version. |
| package-lock.json | Updates lockfile to match the downgraded CLI and bumps lockfileVersion. |
| README.md | Adds Logicrithm to the rendered contributors table. |
| .all-contributorsrc | Adds Logicrithm to the all-contributors config list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Hi @Logicrithm,
Thank you for your PR! ✨
However, we don't want to alter the package.json and package-lock.json files. Please revert them to the original version.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hey @Logicrithm, You haven't revert the |
Description
Added myself as a contributor following the contribution guidelines.
What type of PR is this?
Contributors Checklist
npm run contributors:generatedue to compatibility issues, so I added my entry manually.Added to documentation?