Skip to content

feat: add @Logicrithm as a contributor#951

Open
Logicrithm wants to merge 8 commits into
OpenSource-Communities:mainfrom
Logicrithm:feat/add-contributor
Open

feat: add @Logicrithm as a contributor#951
Logicrithm wants to merge 8 commits into
OpenSource-Communities:mainfrom
Logicrithm:feat/add-contributor

Conversation

@Logicrithm
Copy link
Copy Markdown

Description

Added myself as a contributor following the contribution guidelines.

What type of PR is this?

  • 🤝 Add a contributor

Contributors Checklist

  • ✅ I've read through the Getting Started section
  • ❌ I was unable to run npm run contributors:generate due to compatibility issues, so I added my entry manually.

Added to documentation?

  • 📜 README.md

Copilot AI review requested due to automatic review settings April 23, 2026 08:30
@github-actions
Copy link
Copy Markdown

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @Logicrithm! You're almost to the end of the course!

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this pull request is meant to address.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add @Logicrithm as an all-contributors entry in the repository documentation/config, but it also changes the contributor tooling dependency and regenerates the npm lockfile.

Changes:

  • Add Logicrithm to the all-contributors list in README.md.
  • Add Logicrithm to .all-contributorsrc.
  • Downgrade all-contributors-cli and update package-lock.json (including lockfileVersion change).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Downgrades all-contributors-cli version.
package-lock.json Updates lockfile to match the downgraded CLI and bumps lockfileVersion.
README.md Adds Logicrithm to the rendered contributors table.
.all-contributorsrc Adds Logicrithm to the all-contributors config list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread .all-contributorsrc Outdated
Comment thread package.json Outdated
Copy link
Copy Markdown
Collaborator

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Logicrithm,

Thank you for your PR! ✨

However, we don't want to alter the package.json and package-lock.json files. Please revert them to the original version.

Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@Logicrithm Logicrithm requested a review from adiati98 April 25, 2026 08:43
Logicrithm and others added 3 commits April 27, 2026 19:35
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Author

@Logicrithm Logicrithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@adiati98
Copy link
Copy Markdown
Collaborator

Hey @Logicrithm,

You haven't revert the package-lock.json to the original version.
Please do that and only tag me or the team after you address it.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants