Skip to content

Commit e2d1430

Browse files
committed
Removed unnecessary aria and used semantic html instead
1 parent c20cf71 commit e2d1430

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/components/Welcome.astro

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const resources = [
5555
Skip to main content
5656
</a>
5757

58-
<header class="sticky top-0 bg-white dark:bg-gray-900 shadow-sm z-30" role="banner">
58+
<header class="sticky top-0 bg-white dark:bg-gray-900 shadow-sm z-30">
5959
<div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8">
6060
<div class="flex justify-between h-16">
6161
<!-- Logo/Brand -->
@@ -66,7 +66,7 @@ const resources = [
6666
</div>
6767

6868
<!-- Desktop Navigation -->
69-
<nav class="hidden md:flex space-x-8 items-center" aria-label="Main navigation" role="navigation">
69+
<nav class="hidden md:flex space-x-8 items-center" aria-label="Main navigation">
7070
<a href="/#tips" class="text-gray-800 dark:text-gray-200 hover:text-purple-700 dark:hover:text-purple-300 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:ring-offset-2 px-3 py-2 text-sm font-medium rounded-md">Weekly Tips</a>
7171
<a href="/#shoutouts" class="text-gray-800 dark:text-gray-200 hover:text-purple-700 dark:hover:text-purple-300 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:ring-offset-2 px-3 py-2 text-sm font-medium rounded-md">Shoutouts</a>
7272
<a href="/#courses" class="text-gray-800 dark:text-gray-200 hover:text-purple-700 dark:hover:text-purple-300 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:ring-offset-2 px-3 py-2 text-sm font-medium rounded-md">Courses</a>
@@ -95,15 +95,15 @@ const resources = [
9595
</div>
9696

9797
<!-- Mobile Navigation -->
98-
<div class="hidden md:hidden" id="mobile-menu" role="navigation" aria-label="Mobile navigation">
98+
<nav class="hidden md:hidden" id="mobile-menu" aria-label="Mobile navigation">
9999
<div class="px-2 pt-2 pb-3 space-y-1 sm:px-3">
100100
<a href="/#tips" class="block px-3 py-2 rounded-md text-base font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-none focus:ring-2 focus:ring-purple-500">Weekly Tips</a>
101101
<a href="/#shoutouts" class="block px-3 py-2 rounded-md text-base font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-none focus:ring-2 focus:ring-purple-500">Shoutouts</a>
102102
<a href="/#courses" class="block px-3 py-2 rounded-md text-base font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-none focus:ring-2 focus:ring-purple-500">Courses</a>
103103
<a href="/#resources" class="block px-3 py-2 rounded-md text-base font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-none focus:ring-2 focus:ring-purple-500">Resources</a>
104104
<a href="/about" class="block px-3 py-2 rounded-md text-base font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-none focus:ring-2 focus:ring-purple-500">About</a>
105105
</div>
106-
</div>
106+
</nav>
107107
</header>
108108

109109
<script>
@@ -178,7 +178,7 @@ const resources = [
178178
</div>
179179

180180
<!-- Main Content -->
181-
<main id="main-content" role="main">
181+
<main id="main-content">
182182
<!-- Hero Section -->
183183
<section class="min-h-[80vh] flex flex-col justify-center items-center text-center px-4 relative overflow-hidden" aria-labelledby="hero-heading">
184184
<div class="absolute inset-0 bg-gradient-to-br from-purple-500/20 to-pink-500/20 z-0" aria-hidden="true"></div>

0 commit comments

Comments
 (0)