Address copilot comments

Author: 1-Bart-1

data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml

@@ -17,9 +17,9 @@
 # PANEL DISTRIBUTIONS:
 #   LINEAR:             Uniform panel spacing along wingspan
 #   COSINE:             Cosine clustering (more panels at tips)
-#   COSINE_VAN_GARREL:  Van Garrel's modified cosine distribution
 #   SPLIT_PROVIDED:     Use predefined section splits from geometry
 #   UNCHANGED:          Preserve original geometry discretization
+#   BILLOWING:          Split provided + sinusoidal TE billowing
 #
 # INITIAL CIRCULATION DISTRIBUTIONS:
 #   ELLIPTIC:           Elliptical distribution (optimal for efficiency)
@@ -44,7 +44,7 @@ condition:
 # Define wing geometry files and discretization parameters
 wings:
   - name: V3_Kite # Wing identifier for output labeling
-    geometry_file: data/v3/aero_geometry.yaml
+    geometry_file: data/TUDELFT_V3_KITE/aero_geometry.yaml
     n_panels: 54 # Total number of panels along wingspan
     spanwise_panel_distribution: SPLIT_PROVIDED # Panel spacing algorithm
     spanwise_direction: [0.0, 1.0, 0.0] # Unit vector defining wingspan direction

examples/billowing.jl

@@ -23,7 +23,7 @@ literature_paths = [
     joinpath(lit_dir, "windtunnel_alpha_sweep_beta_00_0_Poland_2025_Rey_5e5.csv"),
 ]
 
-# Load solver settings (coarse: 36 panels, matches 10-section geometry)
+# Load solver settings (coarse: 54 panels, matches 10-section geometry)
 settings_data = VortexStepMethod.YAML.load_file(
     joinpath(v3_dir, "vsm_settings_coarse.yaml"))
 condition_cfg = settings_data["condition"]

ext/VortexStepMethodMakieExt.jl

@@ -780,6 +780,7 @@ Plot polar data comparing different solvers using Makie.
 - `is_save`: Whether to save (default: true)
 - `is_show`: Whether to display (default: true)
 - `use_tex`: Ignored for Makie (default: false)
+- `cl_over_cd`: Plot CL/CD vs angle instead of CL vs CD (default: true)
 """
 function VortexStepMethod.plot_polars(
     solver_list,
@@ -1025,6 +1026,8 @@ Create combined multi-panel figure with geometry, polar data, distributions, and
 - `data_type`: File extension (default: ".png", also supports ".jpeg")
 - `save_path`: Directory path to save files (default: nothing)
 - `is_save`: Save plots to files (default: false)
+- `cl_over_cd`: Plot CL/CD vs angle instead of CL vs CD (default: true)
+- `angle_of_attack_for_spanwise_distribution`: AoA for spanwise plots (default: 5.0)
 """
 function VortexStepMethod.plot_combined_analysis(
     solver,

test/wing_geometry/test_billowing.jl

@@ -51,20 +51,20 @@ function te_arc_length_between_ribs(wing, rib_left, rib_right)
         if isnothing(first_idx)
             if isapprox(sec.LE_point,
                     wing.unrefined_sections[rib_left].LE_point;
-                    atol=1e-10)
+                    atol=1e-8)
                 first_idx = i
             end
         end
         if !isnothing(first_idx) && isnothing(last_idx)
             if isapprox(sec.LE_point,
                     wing.unrefined_sections[rib_right].LE_point;
-                    atol=1e-10)
+                    atol=1e-8)
                 last_idx = i
                 break
             end
         end
     end
-    @assert !isnothing(first_idx) && !isnothing(last_idx)
+    @test !isnothing(first_idx) && !isnothing(last_idx)
     arc = 0.0
     for i in first_idx:(last_idx - 1)
         arc += norm(sections[i + 1].TE_point -
@@ -84,7 +84,7 @@ end
             billowing_percentage=0.0)
         for pair in 1:(n_ribs - 1)
             res = te_arc_length_between_ribs(wing, pair, pair + 1)
-            @test res.arc ≈ res.straight atol=1e-10
+            @test res.arc ≈ res.straight atol=1e-8
         end
     end
 
@@ -97,7 +97,7 @@ end
             for sec in wing.refined_sections
                 if isapprox(sec.LE_point,
                         wing.unrefined_sections[i].LE_point;
-                        atol=1e-10)
+                        atol=1e-8)
                     @test isapprox(sec.TE_point,
                         wing.unrefined_sections[i].TE_point;
                         atol=1e-6)
@@ -139,7 +139,7 @@ end
         for sec in wing.refined_sections
             chord = norm(sec.TE_point - sec.LE_point)
             # All ribs have chord=1.0, so interpolated chord=1.0
-            @test isapprox(chord, 1.0; atol=1e-10)
+            @test isapprox(chord, 1.0; atol=1e-8)
         end
     end
 
@@ -209,20 +209,20 @@ end
 
         # Zero angle is identity
         r = rodrigues_rotate(v, axis, 0.0)
-        @test isapprox(r, v; atol=1e-14)
+        @test isapprox(r, v; atol=1e-12)
 
         # 90 degrees around z rotates x -> y
         r90 = rodrigues_rotate(v, axis, pi / 2)
-        @test isapprox(r90, MVec3(0.0, 1.0, 0.0); atol=1e-14)
+        @test isapprox(r90, MVec3(0.0, 1.0, 0.0); atol=1e-12)
 
         # 180 degrees around z rotates x -> -x
         r180 = rodrigues_rotate(v, axis, pi)
-        @test isapprox(r180, MVec3(-1.0, 0.0, 0.0); atol=1e-14)
+        @test isapprox(r180, MVec3(-1.0, 0.0, 0.0); atol=1e-12)
 
         # Rotation preserves vector length
         v2 = MVec3(3.0, 4.0, 0.0)
         r2 = rodrigues_rotate(v2, axis, 1.23)
-        @test isapprox(norm(r2), norm(v2); atol=1e-14)
+        @test isapprox(norm(r2), norm(v2); atol=1e-12)
     end
 
     @testset "Fast path: n_panels == n_provided warns" begin
@@ -246,8 +246,8 @@ end
         # All refined sections should match unrefined exactly
         for (ref, unref) in zip(
                 wing.refined_sections, wing.unrefined_sections)
-            @test isapprox(ref.LE_point, unref.LE_point; atol=1e-10)
-            @test isapprox(ref.TE_point, unref.TE_point; atol=1e-10)
+            @test isapprox(ref.LE_point, unref.LE_point; atol=1e-8)
+            @test isapprox(ref.TE_point, unref.TE_point; atol=1e-8)
         end
     end
 end