Fix warnings

Author: ufechner7

src/obj_geometry.jl

@@ -528,9 +528,9 @@ function ObjWing(
     # Load or create polars
     (!endswith(dat_path, ".dat")) && (dat_path *= ".dat")
     (!isfile(dat_path)) && error("DAT file not found: $dat_path")
-    cl_polar_path = dat_path[1:end-4] * "_cl_polar.csv"
-    cd_polar_path = dat_path[1:end-4] * "_cd_polar.csv"
-    cm_polar_path = dat_path[1:end-4] * "_cm_polar.csv"
+    cl_polar_path = string(dat_path[1:end-4], "_cl_polar.csv")
+    cd_polar_path = string(dat_path[1:end-4], "_cd_polar.csv")
+    cm_polar_path = string(dat_path[1:end-4], "_cm_polar.csv")
 
     (!endswith(obj_path, ".obj")) && (obj_path *= ".obj")
     (!isfile(obj_path)) && error("OBJ file not found: $obj_path")
@@ -557,9 +557,9 @@ function ObjWing(
                 area, width, crease_frac, alpha_range, delta_range, remove_nan)
         end
 
-        cl_matrix, _, _ = read_aero_matrix(cl_polar_path)
-        cd_matrix, _, _ = read_aero_matrix(cd_polar_path)
-        cm_matrix, alpha_range, delta_range = read_aero_matrix(cm_polar_path)
+        cl_matrix, _, _ = read_aero_matrix(String(cl_polar_path))
+        cd_matrix, _, _ = read_aero_matrix(String(cd_polar_path))
+        cm_matrix, alpha_range, delta_range = read_aero_matrix(String(cm_polar_path))
 
         if remove_nan
             any(isnan.(cl_matrix)) && interpolate_matrix_nans!(cl_matrix; prn)

src/polars.jl

@@ -72,12 +72,9 @@ function solve_alpha!(cls, cds, cms, alpha_range, alpha_idxs, delta, re, x_, y_,
     y = deepcopy(y_)
     turn_trailing_edge!(delta, x, y, lower, upper, crease_frac)
     Xfoil.set_coordinates(x, y)
-    x, y = Xfoil.pane(npan=140)
+    Xfoil.pane(npan=140)
     reinit = true
     for (alpha, alpha_idx) in zip(alpha_range, alpha_idxs)
-        converged = false
-        cl = 0.0
-        cd = 0.0
         # Solve for the given angle of attack
         cl, cd, _, cm, converged = Xfoil.solve_alpha(rad2deg(alpha), re; iter=50, reinit=reinit, mach=kite_speed/speed_of_sound, xtrip=(0.05, 0.05))
         reinit = false
@@ -308,23 +305,29 @@ The first row contains flap deflection angles, first column contains angles of a
 - `delta_range`: Vector of flap deflection angles in radians
 - `label`: Coefficient label for the header
 """
-function write_aero_matrix(filepath::String, matrix::Matrix{Float64}, 
+function write_aero_matrix(filepath::AbstractString, matrix::Matrix{Float64}, 
                          alpha_range::Vector{Float64}, delta_range::Vector{Float64},
-                         label::String)
-    open(filepath, "w") do io
+                         label::AbstractString)
+    open(String(filepath), "w") do io
         # Write header with delta values
-        println(io, "$label/delta," * join(["δ=$(round(rad2deg(δ), digits=1))°" for δ in delta_range], ","))
+        delta_labels = ["δ=$(round(rad2deg(δ), digits=1))°" for δ in delta_range]
+        deltas_str = join(delta_labels, ",")
+        deltas_str isa String || throw(ArgumentError("Failed to serialize delta header labels."))
+        header = string(label, "/delta,", deltas_str)
+        println(io, header)
 
         # Write data rows with alpha values and coefficients
         for i in eachindex(alpha_range)
-            row = "α=$(round(rad2deg(alpha_range[i]), digits=1))°," * join(matrix[i,:], ",")
+            coeffs_str = join(matrix[i,:], ",")
+            coeffs_str isa String || throw(ArgumentError("Failed to serialize coefficient row."))
+            row = string("α=$(round(rad2deg(alpha_range[i]), digits=1))°,", coeffs_str)
             println(io, row)
         end
     end
 end
 
 """
-    read_aero_matrix(filepath::String) -> (Matrix{Float64}, Vector{Float64}, Vector{Float64})
+    read_aero_matrix(filepath::AbstractString) -> (Matrix{Float64}, Vector{Float64}, Vector{Float64})
 
 Read an aerodynamic coefficient matrix from CSV with angle labels.
 Returns the coefficient matrix and corresponding angle ranges.
@@ -334,15 +337,18 @@ Returns the coefficient matrix and corresponding angle ranges.
 - `alpha_range`: Vector of angle of attack values in radians
 - `delta_range`: Vector of flap deflection angles in radians
 """
-function read_aero_matrix(filepath::String)
-    lines = readlines(filepath)
+function read_aero_matrix(filepath::AbstractString)
+    lines = readlines(String(filepath))
 
     # Parse header to get delta values
     header = split(lines[1], ',')
     delta_values = map(header[2:end]) do δ_str
         # Extract number between "δ=" and "°"
         m = match(r"δ=(-?\d+\.?\d*)°", δ_str)
-        deg2rad(parse(Float64, m.captures[1]))
+        m === nothing && throw(ArgumentError("Invalid delta header entry: $δ_str"))
+        δ_cap = m.captures[1]
+        (δ_cap isa AbstractString) || throw(ArgumentError("Missing delta value in header entry: $δ_str"))
+        deg2rad(parse(Float64, String(δ_cap)))
     end
 
     # Initialize matrix
@@ -356,7 +362,10 @@ function read_aero_matrix(filepath::String)
         entries = split(line, ',')
         # Extract alpha value
         m = match(r"α=(-?\d+\.?\d*)°", entries[1])
-        alpha_values[i] = deg2rad(parse(Float64, m.captures[1]))
+        m === nothing && throw(ArgumentError("Invalid alpha row entry: $(entries[1])"))
+        α_cap = m.captures[1]
+        (α_cap isa AbstractString) || throw(ArgumentError("Missing alpha value in row entry: $(entries[1])"))
+        alpha_values[i] = deg2rad(parse(Float64, String(α_cap)))
         # Parse coefficient values
         matrix[i,:] .= parse.(Float64, entries[2:end])
     end