Adiciona testes e mocks de verificação de endereço e casos extremos#1030
Open
kevinrvb16 wants to merge 1 commit intoOpenSourceFellows:mainfrom
Open
Adiciona testes e mocks de verificação de endereço e casos extremos#1030kevinrvb16 wants to merge 1 commit intoOpenSourceFellows:mainfrom
kevinrvb16 wants to merge 1 commit intoOpenSourceFellows:mainfrom
Conversation
|
Hello there, thanks for opening your first Pull Request. Someone will review it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the test coverage for the Lob address verification API by introducing structured mock data and dynamic tests for both standard and edge case addresses.
Key Changes:
Created a mock model file (addresses.js) containing two arrays:
addresses: standard mock addresses for general testing.
addressEdgeCases: a comprehensive set of edge case addresses (e.g., satellites, non-residential, P.O. boxes, military, Puerto Rico, etc.) with expected results.
Updated the integration test (lob.test.js):
Imports both addresses and addressEdgeCases from the mock file.
Adds a new test suite that dynamically iterates over addressEdgeCases, asserting the API response matches the expected result for each edge case.
Adds a dynamic test for the basic addresses array to ensure all mock addresses are handled by the endpoint.
Ensures maintainability and scalability by centralizing mock data and making it easy to add new cases in the future.
Motivation:
This change ensures that all relevant address scenarios, including edge cases, are consistently tested. It also makes the test code cleaner and easier to extend as new requirements or edge cases arise.
How to test:
Run the test suite with npm test or npx jest and verify that all address verification scenarios pass as expected.