Add custom fly-to duration slider#228
Open
alexanderbock wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a user-configurable “Override Fly-to Duration” setting to the Navigation Settings popout, storing the preference in local Redux state and applying it when executing navigation.flyTo.
Changes:
- Extend
LocalStatewithmenus.navigation.flyToOverrideDuration(enabled + duration) and add reducers to update it. - Add a checkbox + slider + numeric input to Navigation Settings to control the override.
- Apply the override duration in
NodeNavigationButtonwhen triggering Fly navigation. - Add the new English translation key for the settings label.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/redux/local/localSlice.ts |
Adds local Redux state + actions for fly-to duration override. |
src/panels/NavigationPanel/NavigationSettings.tsx |
Adds UI controls (checkbox + slider + numeric input) to manage the override. |
src/components/NodeNavigationButton/NodeNavigationButton.tsx |
Uses the override duration when calling luaApi.navigation.flyTo. |
public/locales/en/panel-navigation.json |
Adds the translation string for the new setting label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Needs an info button to explain the interaction with the speed scale slider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new optional slider to the Navigation Settings menu that can control whether to provide a custom duration:
After:

Before:
