Add institutions, contributions, and third party information to the About window#229
Open
alexanderbock wants to merge 6 commits into
Open
Add institutions, contributions, and third party information to the About window#229alexanderbock wants to merge 6 commits into
alexanderbock wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the About modal to include stewarding institutions, GitHub contributors (across OpenSpace/OpenSpace, OpenSpace/Ghoul, and OpenSpace/OpenSpace-WebGui), and a third-party licenses section backed by a generated TypeScript data file.
Changes:
- Adds a new Redux slice + async thunk to fetch and aggregate GitHub contributors across multiple repos.
- Extends the About modal UI to render contributor avatars/links and third-party license details via collapsible sections.
- Introduces a
scripts/generateThirdParty.tsgenerator and its generated output (src/data/ThirdPartyDependencies.ts) plus new i18n strings.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/redux/store.ts | Registers the new contributors reducer in the Redux store. |
| src/redux/contributors/contributorsSlice.ts | Adds contributors slice state (contributors, status) wired to thunk lifecycle. |
| src/redux/contributors/contributorsMiddleware.ts | Implements GitHub API fetching, pagination, and contribution aggregation. |
| src/components/About/About.tsx | Updates About modal layout, triggers contributor fetch, and renders contributors + third-party licenses. |
| src/data/ThirdPartyDependencies.ts | Adds generated third-party dependency metadata including full license texts. |
| scripts/generateThirdParty.ts | Adds generator script to parse a markdown license file and emit ThirdPartyDependencies.ts. |
| public/locales/en/components.json | Adds new About modal translation strings (institutions, contributors, third-party labels). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -55,6 +80,66 @@ export function About({ opened, close }: Props) { | |||
| <Anchor href={'https://www.openspaceproject.com/'} target={'_blank'}> | |||
Comment on lines
+23
to
+24
| import fs from 'fs'; | ||
| import path from 'path'; |
Comment on lines
+126
to
+130
| const output = generateTypeScript(dependencies); | ||
|
|
||
| fs.mkdirSync(path.dirname(outputPath), { recursive: true }); | ||
| fs.writeFileSync(outputPath, output, 'utf-8'); | ||
|
|
Comment on lines
+1
to
+4
| // This file is auto-generated. Do not edit manually. | ||
| // To regenerate, run: | ||
| // npx tsx scripts/generateThirdParty.ts <path-to-license.md> | ||
|
|
Comment on lines
+17
to
+20
| import { Collapsable } from '@/components/Collapsable/Collapsable'; | ||
| import { ThirdPartyDependencies } from '@/data/ThirdPartyDependencies'; | ||
| import { getContributors } from '@/redux/contributors/contributorsMiddleware'; | ||
| import { useAppDispatch, useAppSelector } from '@/redux/hooks'; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional information into the About window. Stewarding institutions are now mentioned as well as contributors to the main repos (OpenSpace/OpenSpace, OpenSpace/Ghoul, and OpenSpace-WebGui). The contributors are sorted by numbre of contributions and contain the GitHub logo and a link to the GitHub page.
Also adds a new script that parses OpenSpace's THIRD_PARTY_LIBRARIES file to add that information to the About panel as well.
Before:
After:
