OpenStickCommunity
diff --git a/‎CMakeLists.txt‎
Lines changed: 3 additions & 1 deletion b/‎CMakeLists.txt‎
Lines changed: 3 additions & 1 deletion
diff --git a/‎headers/display/GPGFX_UI.h‎
Lines changed: 2 additions & 2 deletions b/‎headers/display/GPGFX_UI.h‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎headers/display/GPGFX_UI_types.h‎
Lines changed: 2 additions & 2 deletions b/‎headers/display/GPGFX_UI_types.h‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎headers/display/ui/elements/GPWidget.h‎
Lines changed: 1 addition & 1 deletion b/‎headers/display/ui/elements/GPWidget.h‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎headers/display/ui/screens/ButtonLayoutScreen.h‎
Lines changed: 14 additions & 14 deletions b/‎headers/display/ui/screens/ButtonLayoutScreen.h‎
Lines changed: 14 additions & 14 deletions
diff --git a/‎headers/display/ui/screens/DisplaySaverScreen.h‎
Lines changed: 1 addition & 1 deletion b/‎headers/display/ui/screens/DisplaySaverScreen.h‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎headers/display/ui/screens/MainMenuScreen.h‎
Lines changed: 30 additions & 28 deletions b/‎headers/display/ui/screens/MainMenuScreen.h‎
Lines changed: 30 additions & 28 deletions
diff --git a/‎headers/display/ui/screens/RestartScreen.h‎
Lines changed: 1 addition & 1 deletion b/‎headers/display/ui/screens/RestartScreen.h‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎headers/display/ui/screens/SplashScreen.h‎
Lines changed: 1 addition & 1 deletion b/‎headers/display/ui/screens/SplashScreen.h‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎headers/display/ui/screens/StatsScreen.h‎
Lines changed: 7 additions & 7 deletions b/‎headers/display/ui/screens/StatsScreen.h‎
Lines changed: 7 additions & 7 deletions
@@ -169,6 +169,8 @@ compile_proto()
 #pull in tinyUSB
 set(PICO_TINYUSB_PATH "${CMAKE_CURRENT_LIST_DIR}/lib/tinyusb")
 
+set(PICO_USE_FASTEST_SUPPORTED_CLOCK 1)
+
 # initialize the Raspberry Pi Pico SDK
 pico_sdk_init()
 
@@ -180,7 +182,7 @@ add_subdirectory(lib)
 
 if(CMAKE_BUILD_TYPE STREQUAL "Debug")
   # Activate some compiler / linker options to aid us with diagnosing stack space issues in Debug builds
-  add_compile_options(-fstack-usage -Wstack-usage=500)
+  add_compile_options(-fstack-usage -Wstack-usage=500 -Wnull-dereference -Wcast-align -Wimplicit-fallthrough)
   add_compile_definitions(PICO_USE_STACK_GUARDS=1)
 endif()
 
 
@@ -23,8 +23,8 @@ class GPGFX_UI {
         DisplayOptions getDisplayOptions();
     private:
         GPGFX* _renderer;
-        DisplayOptions _displayOptions;
-        bool _configMode;
+        DisplayOptions _displayOptions{};
+        bool _configMode = false;
 };
 
 #endif
@@ -7,8 +7,8 @@
 
 typedef struct MenuEntry {
     std::string label;
-    uint8_t* icon;
-    std::vector<MenuEntry>* submenu;
+    uint8_t* icon = nullptr;
+    std::vector<MenuEntry>* submenu = nullptr;
     std::function<int32_t()> currentValue;
     std::function<void()> action;
     int32_t optionValue = -1;
 
@@ -38,7 +38,7 @@ class GPWidget : public GPGFX_UI {
 
         uint16_t strokeColor = 0;
         uint16_t fillColor = 0;
-        uint16_t _ID;
+        uint16_t _ID = 0;
         uint16_t _priority = 0;
         bool _visibility = true;
 
 
@@ -18,7 +18,7 @@
 #define INPUT_HISTORY_MAX_MODES 12
 
 // Static to ensure memory is never doubled
-static const char * displayNames[INPUT_HISTORY_MAX_MODES][INPUT_HISTORY_MAX_INPUTS] = {
+static const char * displayNames[INPUT_HISTORY_MAX_MODES][INPUT_HISTORY_MAX_INPUTS] __attribute__((unused)) = {
     {		// PS3 - 0
             CHAR_UP, CHAR_DOWN, CHAR_LEFT, CHAR_RIGHT,
             CHAR_UL, CHAR_UR, CHAR_DL, CHAR_DR,
@@ -147,35 +147,35 @@ class ButtonLayoutScreen : public GPScreen {
             {INPUT_MODE_GENERIC, 11},
         };
 
-        Gamepad* gamepad;
-        InputMode inputMode;
-        std::string statusBar;
-        std::string footer;
+        Gamepad* gamepad = nullptr;
+        InputMode inputMode = INPUT_MODE_XINPUT;
+        std::string statusBar{};
+        std::string footer{};
 
         bool isInputHistoryEnabled = false;
         uint16_t inputHistoryX = 0;
         uint16_t inputHistoryY = 0;
         size_t inputHistoryLength = 0;
-        std::string historyString;
-        std::deque<std::string> inputHistory;
-        std::array<bool, INPUT_HISTORY_MAX_INPUTS> lastInput;
+        std::string historyString{};
+        std::deque<std::string> inputHistory{};
+        std::array<bool, INPUT_HISTORY_MAX_INPUTS> lastInput{};
 
-        bool bannerDisplay;
+        bool bannerDisplay = false;
         uint8_t bannerDelay = 2;
         int bannerDelayStart = 0;
-        std::string bannerMessage;
+        std::string bannerMessage{};
         uint16_t prevButtonState = 0;
         uint8_t prevLayoutLeft = 0;
         uint8_t prevLayoutRight = 0;
         uint8_t profileNumber = 0;
         uint8_t prevProfileNumber = 0;
-        ButtonLayoutParamsLeft prevLeftOptions;
-        ButtonLayoutParamsRight prevRightOptions;
-        ButtonLayoutOrientation prevOrientation;
+        ButtonLayoutParamsLeft prevLeftOptions{};
+        ButtonLayoutParamsRight prevRightOptions{};
+        ButtonLayoutOrientation prevOrientation{};
 
         bool hasTurboAssigned = false;
 
-        bool macroEnabled;
+        bool macroEnabled = false;
 
         bool showInputMode = true;
         bool showTurboMode = true;
 
@@ -18,7 +18,7 @@ class DisplaySaverScreen : public GPScreen {
     protected:
         virtual void drawScreen();
         uint16_t prevButtonState = 0;
-        DisplaySaverMode displaySaverMode;
+        DisplaySaverMode displaySaverMode{};
 
         // snow screen
         uint8_t snowflakeSpeeds[SCREEN_WIDTH][SCREEN_HEIGHT] = {};
 
@@ -80,16 +80,16 @@ class MainMenuScreen : public GPScreen {
         virtual void drawScreen();
     private:
         bool isPressed = false;
-        uint32_t checkDebounce;
-        std::vector<MenuEntry>* currentMenu;
-        std::vector<MenuEntry>* previousMenu;
+        uint32_t checkDebounce = 0;
+        std::vector<MenuEntry>* currentMenu = nullptr;
+        std::vector<MenuEntry>* previousMenu = nullptr;
         uint16_t prevButtonState = 0;
         uint8_t prevDpadState = 0;
-        Mask_t prevValues;
+        Mask_t prevValues = 0;
         GPMenu* gpMenu = nullptr;
         const uint8_t menuLineSize = 4;
 
-        GpioAction eventAction;
+        GpioAction eventAction = GpioAction::NONE;
 
         bool screenIsPrompting = false;
         bool promptChoice = false;
@@ -98,13 +98,13 @@ class MainMenuScreen : public GPScreen {
         int8_t exitToScreenBeforePrompt = -1;
         int8_t exitToScreen = -1;
 
-        GamepadButtonMapping *mapMenuUp;
-        GamepadButtonMapping *mapMenuDown;
-        GamepadButtonMapping *mapMenuLeft;
-        GamepadButtonMapping *mapMenuRight;
-        GamepadButtonMapping *mapMenuSelect;
-        GamepadButtonMapping *mapMenuBack;
-        GamepadButtonMapping *mapMenuToggle;
+        GamepadButtonMapping *mapMenuUp = nullptr;
+        GamepadButtonMapping *mapMenuDown = nullptr;
+        GamepadButtonMapping *mapMenuLeft = nullptr;
+        GamepadButtonMapping *mapMenuRight = nullptr;
+        GamepadButtonMapping *mapMenuSelect = nullptr;
+        GamepadButtonMapping *mapMenuBack = nullptr;
+        GamepadButtonMapping *mapMenuToggle = nullptr;
 
         void saveOptions();
         void resetOptions();
@@ -118,39 +118,44 @@ class MainMenuScreen : public GPScreen {
         std::vector<MenuEntry> inputModeMenu = {
             InputMode_VALUELIST(INPUT_MODE_ENTRIES)
         };
-        InputMode prevInputMode;
-        InputMode updateInputMode;
+        InputMode prevInputMode{};
+        InputMode updateInputMode{};
 
         std::vector<MenuEntry> dpadModeMenu = {
             DpadMode_VALUELIST(DPAD_MODE_ENTRIES)
         };
-        DpadMode prevDpadMode;
-        DpadMode updateDpadMode;
+        DpadMode prevDpadMode{};
+        DpadMode updateDpadMode{};
 
         std::vector<MenuEntry> socdModeMenu = {
             SOCDMode_VALUELIST(SOCD_MODE_ENTRIES)
         };
-        SOCDMode prevSocdMode;
-        SOCDMode updateSocdMode;
+        SOCDMode prevSocdMode{};
+        SOCDMode updateSocdMode{};
 
         std::vector<MenuEntry> profilesMenu = {};
-        uint8_t prevProfile;
-        uint8_t updateProfile;
+        uint8_t prevProfile{};
+        uint8_t updateProfile{};
 
         std::vector<MenuEntry> focusModeMenu = {
             {"Off",        NULL, nullptr,        std::bind(&MainMenuScreen::currentFocusMode, this), std::bind(&MainMenuScreen::selectFocusMode, this), 0},
             {"On",         NULL, nullptr,        std::bind(&MainMenuScreen::currentFocusMode, this), std::bind(&MainMenuScreen::selectFocusMode, this), 1},
         };
-        bool prevFocus;
-        bool updateFocus;
+        bool prevFocus = false;
+        bool updateFocus = false;
 
         std::vector<MenuEntry> turboModeMenu = {
             {"Off",        NULL, nullptr,        std::bind(&MainMenuScreen::currentTurboMode, this), std::bind(&MainMenuScreen::selectTurboMode, this), 0},
             {"On",         NULL, nullptr,        std::bind(&MainMenuScreen::currentTurboMode, this), std::bind(&MainMenuScreen::selectTurboMode, this), 1},
         };
-        bool prevTurbo;
-        bool updateTurbo;
+        bool prevTurbo = false;
+        bool updateTurbo = false;
 
+        std::vector<MenuEntry> saveMenu = {
+            {"Save & Exit",NULL, nullptr,        std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::saveAndExit, this), 1},
+            {"Exit",       NULL, nullptr,        std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::exitOnly, this), 0},
+        };
+        
         std::vector<MenuEntry> mainMenu = {
             {"Input Mode", NULL, &inputModeMenu, std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::testMenu, this)},
             {"D-Pad Mode", NULL, &dpadModeMenu,  std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::testMenu, this)},
@@ -161,10 +166,7 @@ class MainMenuScreen : public GPScreen {
             {"Exit",       NULL, &saveMenu,      std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::testMenu, this)},
         };
 
-        std::vector<MenuEntry> saveMenu = {
-            {"Save & Exit",NULL, nullptr,        std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::saveAndExit, this), 1},
-            {"Exit",       NULL, nullptr,        std::bind(&MainMenuScreen::modeValue, this), std::bind(&MainMenuScreen::exitOnly, this), 0},
-        };
+        
 };
 
 #endif
@@ -15,7 +15,7 @@ class RestartScreen : public GPScreen {
         void setBootMode(uint32_t mode);
     protected:
         virtual void drawScreen();
-        uint32_t bootMode;
+        uint32_t bootMode = 0;
 };
 
 #endif
@@ -15,7 +15,7 @@ class SplashScreen : public GPScreen {
         virtual void drawScreen();
         uint16_t prevButtonState = 0;
         uint32_t splashStartTime = 0;
-        bool configMode;
+        bool configMode = false;
 };
 
 #endif
@@ -15,13 +15,13 @@ class StatsScreen : public GPScreen {
         virtual void drawScreen();
         uint16_t prevButtonState = 0;
 
-        GPLabel* header;
-        GPLabel* version;
-        GPLabel* build;
-        GPLabel* board;
-        GPLabel* boardType;
-        GPLabel* arch;
-        GPLabel* exit;
+        GPLabel* header = nullptr;
+        GPLabel* version = nullptr;
+        GPLabel* build = nullptr;
+        GPLabel* board = nullptr;
+        GPLabel* boardType = nullptr;
+        GPLabel* arch = nullptr;
+        GPLabel* exit = nullptr;
 };
 
 #endif