Change makefile to generate an automatic version for the baseset and newgrfs#223
Merged
Conversation
glx22
reviewed
Dec 8, 2025
zephyris
force-pushed
the
auto-versioning
branch
3 times, most recently
from
000b120 to
564bafa
Compare
LordAro
reviewed
Dec 15, 2025
Cache repo version information in makefile.vcs, including generation of a BASESET_VERSION which is guaranteed to increase day-by-day
Passes manually set user-facing version and automatically determined baseset version to the obg-generating Python script (fixes #222)
For lines directly from a pnml, rather than an included pnml, the result from checking for alternate sprites for a line was not used.
Passes automatically determined baseset version as newgrf version to the nml preprocessing Python script
zephyris
force-pushed
the
auto-versioning
branch
from
564bafa to
9562d45
Compare
LordAro
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions were hard-coded in various places, problematic as overlooking one can mess up versioning. Versioning used an integer version for the internal version of basesets and NewGRFs (1, 2, 3, ..., 8), and a user-facing semantic version (0.1, 0.2, 0.3, ..., 0.8).
This series of changes:
The makefile variables and rules for the versions used by the CDN upload prep rules are unchanged.