Skip to content

Commit 7000679

Browse files
committed
refactor(models): drop legacy flat-kwargs constructor
1 parent 7311524 commit 7000679

1 file changed

Lines changed: 7 additions & 17 deletions

File tree

deeptab/models/base.py

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ def __init__(
148148
trainer_config=None,
149149
observability_config: ObservabilityConfig | None = None,
150150
random_state=None,
151-
**kwargs,
152151
):
153152
model_cls = type(self)._model_cls
154153
config_cls = type(self)._config_cls
@@ -202,28 +201,19 @@ def __init__(
202201
self._optimizer_type = getattr(self.trainer_config, "optimizer_type", "Adam")
203202
self._optimizer_kwargs = {}
204203
else:
205-
# ---- Legacy flat-kwargs path (backward compat) ----
204+
# ---- No configs provided: fall back to defaults ----
206205
self.model_config = None
207206
self.preprocessing_config = None
208207
self.trainer_config = None
209208

210-
self._config_kwargs = {
211-
k: v
212-
for k, v in kwargs.items()
213-
if k not in self._preprocessor_arg_names and not k.startswith("optimizer")
214-
}
215-
self.config = config_cls(**self._config_kwargs)
209+
self._config_kwargs = {}
210+
self.config = config_cls()
216211

217-
self._preprocessor_kwargs = {k: v for k, v in kwargs.items() if k in self._preprocessor_arg_names}
218-
self._preprocessor = Preprocessor(**self._preprocessor_kwargs)
212+
self._preprocessor_kwargs = {}
213+
self._preprocessor = Preprocessor()
219214

220-
self._optimizer_type = kwargs.get("optimizer_type", "Adam")
221-
self._optimizer_kwargs = {
222-
k: v
223-
for k, v in kwargs.items()
224-
if k not in ["lr", "weight_decay", "patience", "lr_patience", "optimizer_type"]
225-
and k.startswith("optimizer_")
226-
}
215+
self._optimizer_type = "Adam"
216+
self._optimizer_kwargs = {}
227217

228218
self._estimator = model_cls
229219
self._task_model = None

0 commit comments

Comments
 (0)