Commit 1ef54aa
committed
Switch ImGuiColorTextEdit to goossens fork
Addresses #155.
Switched from Joshs fork to goossens' fork of ImGuiColorTextEdit
for better performance with larger OTIO files, which were not highlighted
at a satisfactory speed before. One downside: this implementation drops the
special highlighting of the "OTIO_SCHEMA" string found in the original code.
The old fork used regex patterns to highlight the string. The new fork requires a custom tokenizer wrapper to achieve this, which I figured is too much overhead
for minimal benefit. Added TODO comment documenting the decision
and implementation approach for future reference.
This commit completes the dependency upgrade started in the previous
commit. The two commits are separated for review purposes (dependency
upgrade vs. fork switch), but the first commit requires this one to
build successfully.
Submodule changes:
- URL: github.com/jminor/ImGuiColorTextEdit → github.com/goossens/ImGuiColorTextEdit
- Commit: 7dec5d8 (Nov 2022) → a74fb09 (May 2026, master branch)
API migrations in inspector.cpp:
- OTIOLanguageDef() → OTIOLanguage() (LanguageDefinition → Language class)
- SetReadOnly() → SetReadOnlyEnabled()
- SetLanguageDefinition() → SetLanguage()
- SetErrorMarkers() → ClearMarkers() + AddMarker()
- Render(title, false, size) → Render(title, size)
- IsTextChanged() → CanUndo()
- Added palette initialization to fix static initialization order bug
- Removed global otioLangDef variable
Disclosure: I used Claude Sonnet 4.5 to help with the porting process.1 parent 5fb972b commit 1ef54aa
3 files changed
Lines changed: 45 additions & 53 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
32 | | - | |
| 34 | + | |
33 | 35 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| 36 | + | |
| 37 | + | |
64 | 38 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
71 | 53 | | |
72 | | - | |
| 54 | + | |
| 55 | + | |
73 | 56 | | |
74 | 57 | | |
75 | 58 | | |
76 | | - | |
77 | 59 | | |
78 | 60 | | |
79 | 61 | | |
80 | 62 | | |
81 | 63 | | |
82 | 64 | | |
83 | | - | |
84 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
85 | 74 | | |
86 | | - | |
| 75 | + | |
87 | 76 | | |
88 | 77 | | |
89 | 78 | | |
| |||
122 | 111 | | |
123 | 112 | | |
124 | 113 | | |
| 114 | + | |
125 | 115 | | |
126 | | - | |
127 | | - | |
128 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
129 | 121 | | |
130 | 122 | | |
131 | 123 | | |
| |||
222 | 214 | | |
223 | 215 | | |
224 | 216 | | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
230 | 222 | | |
231 | 223 | | |
232 | 224 | | |
233 | 225 | | |
234 | 226 | | |
235 | | - | |
| 227 | + | |
236 | 228 | | |
237 | 229 | | |
238 | 230 | | |
| |||
Submodule ImGuiColorTextEdit updated 44 files
- .github/workflows/linux.yml+23
- .github/workflows/macos.yml+20
- .github/workflows/windows.yml+17
- .gitignore+10-27
- CODE_OF_CONDUCT.md+133
- CONTRIBUTING+48-9
- ImGuiDebugPanel.cpp-47
- LICENSE+1-1
- LanguageDefinitions.cpp-946
- README.md+398-25
- TextDiff.cpp+554
- TextDiff.h+106
- TextEditor.cpp+9.1k-2.8k
- TextEditor.h+1.4k-492
- UnitTests.cpp-221
- docs/architecture.png
- docs/autocomplete.md+176
- docs/autocomplete.png
- docs/contextMenus.md+18
- docs/contextMenus.png
- docs/glsl.cpp+187
- docs/lineDecorator.md+50
- docs/lineDecorator.png
- docs/markers.md+16
- docs/markers.png
- docs/textDiffCombined.png
- docs/textDiffSideBySide.png
- docs/textEditor.png
- docs/userData.md+98
- dtl.h+1.3k
- example/CMakeLists.txt+30
- example/README.md+52
- example/dejavu.cpp+5.4k
- example/dejavu.h+24
- example/dejavu.lic+185
- example/deps/CMakeLists.txt+11
- example/deps/imgui/CMakeLists.txt+32
- example/deps/imguifiledialog/CMakeLists.txt+18
- example/deps/imguifiledialog/IgfdConfig.h+26
- example/deps/sdl/CMakeLists.txt+17
- example/editor.cpp+735
- example/editor.h+98
- example/main.cpp+156
- example/screenshot.png
0 commit comments