Skip to content

Commit 3d32cd7

Browse files
committed
Corrected feather-tk declarations for updated API
1 parent 8dfa36e commit 3d32cd7

2 files changed

Lines changed: 8 additions & 20 deletions

File tree

Dockerfile

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,13 @@ RUN apt-get update && apt-get install -y build-essential \
3434
libopencolorio-dev \
3535
libopentimelineio-dev
3636

37-
# TODO:
38-
39-
# missing #include <ftk/Core/ObservableValue.h> replace with #include <ftk/Core/Observable.h>
40-
# Missing OpenFX/ofxProperty.h need to install OpenFX headers properly.
41-
4237
# Clone, compile and install feather-tk library
4338
RUN mkdir feather-tk
4439
RUN cd feather-tk; git clone https://github.com/grizzlypeak3d/feather-tk.git
4540
RUN cd feather-tk; sh feather-tk/sbuild-linux.sh feather-tk
4641
# TODO replace with cmake --target install
4742
RUN tar -C feather-tk/install-Release -c -f - . | tar -C /usr/local -x -f -
4843

49-
5044
# Add the pipx installation location:
5145
ENV PATH=/root/.local/share/pipx/venvs/conan/bin:$PATH
5246

@@ -60,18 +54,12 @@ RUN conan profile detect
6054
RUN git clone https://github.com/AcademySoftwareFoundation/openfx.git
6155
# TODO this doesn't build on arm64 Linux currently, can't find the architecture.
6256
RUN cd openfx; scripts/build-cmake.sh
63-
# TODO need to fully install this?
57+
# TODO need to find a better installation method, cmake --target install
6458
RUN mkdir /usr/local/include/OpenFX
65-
RUN tar -C include -c -f - . | tar -C /usr/local/include/OpenFX -x -f -
59+
RUN tar -C openfx/include -c -f - . | tar -C /usr/local/include/OpenFX -x -f -
6660

6761
# RUN git clone https://github.com/OpenTimelineIO/toucan.git
6862
# RUN git clone https://github.com/leighsmith/toucan.git
6963
COPY . /home/ubuntu/toucan
7064

7165
# RUN sh toucan/sbuild-linux.sh
72-
73-
74-
# python3-venv \
75-
# python3-pip
76-
# RUN python3 -m venv /home/ubuntu/toucan_python
77-
# RUN /home/ubuntu/toucan_python/bin/pip install conan

lib/toucanView/CompareMenu.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace toucan
2424

2525
_actions["Compare/A"] = ftk::Action::create(
2626
"A",
27-
KeyShortcut(ftk::Key::A, ftk::KeyModifier::Shift),
27+
ftk::KeyShortcut(ftk::Key::A, ftk::KeyModifier::Shift),
2828
[this](bool)
2929
{
3030
CompareOptions options = _filesModel->getCompareOptions();
@@ -35,7 +35,7 @@ namespace toucan
3535

3636
_actions["Compare/B"] = ftk::Action::create(
3737
"B",
38-
KeyShortcut(ftk::Key::B, ftk::KeyModifier::Shift),
38+
ftk::KeyShortcut(ftk::Key::B, ftk::KeyModifier::Shift),
3939
[this](bool)
4040
{
4141
CompareOptions options = _filesModel->getCompareOptions();
@@ -46,7 +46,7 @@ namespace toucan
4646

4747
_actions["Compare/Split"] = ftk::Action::create(
4848
"Split",
49-
KeyShortcut(ftk::Key::S, ftk::KeyModifier::Shift),
49+
ftk::KeyShortcut(ftk::Key::S, ftk::KeyModifier::Shift),
5050
[this](bool)
5151
{
5252
CompareOptions options = _filesModel->getCompareOptions();
@@ -57,7 +57,7 @@ namespace toucan
5757

5858
_actions["Compare/Overlay"] = ftk::Action::create(
5959
"Overlay",
60-
KeyShortcut(ftk::Key::E, ftk::KeyModifier::Shift),
60+
ftk::KeyShortcut(ftk::Key::E, ftk::KeyModifier::Shift),
6161
[this](bool)
6262
{
6363
CompareOptions options = _filesModel->getCompareOptions();
@@ -68,7 +68,7 @@ namespace toucan
6868

6969
_actions["Compare/Horizontal"] = ftk::Action::create(
7070
"Horizontal",
71-
KeyShortcut(ftk::Key::H, ftk::KeyModifier::Shift),
71+
ftk::KeyShortcut(ftk::Key::H, ftk::KeyModifier::Shift),
7272
[this](bool)
7373
{
7474
CompareOptions options = _filesModel->getCompareOptions();
@@ -79,7 +79,7 @@ namespace toucan
7979

8080
_actions["Compare/Vertical"] = ftk::Action::create(
8181
"Vertical",
82-
KeyShortcut(ftk::Key::V, ftk::KeyModifier::Shift),
82+
ftk::KeyShortcut(ftk::Key::V, ftk::KeyModifier::Shift),
8383
[this](bool)
8484
{
8585
CompareOptions options = _filesModel->getCompareOptions();

0 commit comments

Comments
 (0)