Upgrade for latest feather-tk#60
Open
leighsmith wants to merge 19 commits into
Open
Conversation
3d32cd7 to
407945d
Compare
Collaborator
|
Hi, and thanks for the contribution. The feather-tk library is still in early development and going through a lot of changes, sorry for the churn. For the size hint I believe the change was moving from a setter function Which would be converted into: If that seems like too much work I can take a look, but if you would like to proceed I'm happy to answer any questions. |
Author
|
Thanks, that gives me a good example of the intended upgrade path. I'll see what I can accomplish & report progress. |
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…atest feather-tk Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…Arg to CmdLineArg Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…Arg to CmdLineArg Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…mdLineArg for new feather-tk API Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…mdLineArg for new feather-tk API Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…I function Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…I function Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…() instance Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
…o ::getSizeHint(). These are all ripe for a refactor to create a ToucanWidget class which removes the redunancy of such instance functions Signed-off-by: Leigh Smith <leigh@leighsmith.com>
Signed-off-by: Leigh Smith <leigh@leighsmith.com>
d3b31df to
146cf08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainbranch of feather-tk, which has diverged greatly from the feather-tk API expected by the current Toucan.IWidget::_setSizeHint()while it is used extensively inlib/toucanView(listed below). Further advice is needed for the steps to take to resolve this bit-rot.