Skip to content

Commit 807c522

Browse files
authored
fix: sync deleteJWTcredential when changing password
1 parent 55b2627 commit 807c522

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

apis/account.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -393,15 +393,14 @@ func ChangePassword(c *fiber.Ctx) error {
393393
}
394394

395395
if !config.Config.Standalone {
396-
userID := user.ID
397-
go func() {
398-
err = kong.DeleteJwtCredential(userID)
399-
if err != nil {
400-
log.Warn().Err(err).Int("user_id", userID).Msg("failed to delete jwt credential")
401-
}
402-
}()
396+
err = kong.DeleteJwtCredential(user.ID)
397+
if err != nil {
398+
// When deleting a JWT, if the JWT does not exist, no error is thrown.
399+
log.Warn().Err(err).Int("user_id", user.ID).Msg("failed to delete jwt credential")
400+
}
403401
}
404402

403+
// Do NOT async deleteJwt to ensure that newly created JWTs are not deleted.
405404
accessToken, refreshToken, err := user.CreateJWTToken()
406405
if err != nil {
407406
return err

0 commit comments

Comments
 (0)