Skip to content

Commit 453104d

Browse files
committed
Merge pull request #619 from Martii/googleScopeUpdateForDep
Update deprecated Google classic/standard auth scope to use Google+ scope Auto-merge
2 parents e0987b3 + b300317 commit 453104d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

controllers/auth.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ function getRedirect(aReq) {
5959
exports.auth = function (aReq, aRes, aNext) {
6060
var authedUser = aReq.session.user;
6161
var strategy = aReq.body.auth || aReq.params.strategy;
62-
var username = aReq.body.username || aReq.session.username ||
62+
var username = aReq.body.username || aReq.session.username ||
6363
(authedUser ? authedUser.name : null);
6464
var authOpts = { failureRedirect: '/register?stratfail' };
6565
var passportKey = aReq._passport.instance._key;
6666

67-
// Yet another passport hack.
67+
// Yet another passport hack.
6868
// Initialize the passport session data only when we need it.
6969
if (!aReq.session[passportKey] && aReq._passport.session) {
7070
aReq.session[passportKey] = {};
@@ -83,7 +83,7 @@ exports.auth = function (aReq, aRes, aNext) {
8383
}
8484

8585
if (strategy === 'google') {
86-
authOpts.scope = ['https://www.googleapis.com/auth/userinfo.profile'];
86+
authOpts.scope = ['https://www.googleapis.com/auth/plus.login'];
8787
}
8888
authenticate = passport.authenticate(strategy, authOpts);
8989

views/includes/headerReminders.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="reminders">
22
{{^hideReminder}}
3-
<div class="alert alert-warning alert-dismissible small fade in" role="alert">
3+
<div class="alert alert-danger alert-dismissible small fade in" role="alert">
44
<button type="button" class="close" data-dismiss="alert"><span aria-hidden="true">&times;</span><span class="sr-only">Close</span></button>
55
<p><i class="fa fa-fw fa-exclamation-triangle"></i> <b>REMINDER:</b> Don't miss out reading the <a class="alert-link" href="/announcements/Google_Authentication_Deprecation">Google Authentication Deprecation</a> with migration announcement.</p>
66
</div>

0 commit comments

Comments
 (0)