Skip to content

typechecker: Improve exception thrown for wrong nodes #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flofriday wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

typechecker: Improve exception thrown for wrong nodes #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions vadl/main/vadl/ast/TypeChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,14 +1762,14 @@ public Void visit(ModelDefinition definition) {

@Override
public Void visit(RecordTypeDefinition definition) {
throwUnimplemented(definition);
return null;
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(definition.getClass().getSimpleName()));
}

@Override
public Void visit(ModelTypeDefinition definition) {
throwUnimplemented(definition);
return null;
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(definition.getClass().getSimpleName()));
}

@Override
Expand Down Expand Up @@ -1814,9 +1814,9 @@ public Void visit(Parameter definition) {
}

@Override
public Void visit(GroupDefinition groupDefinition) {
throwUnimplemented(groupDefinition);
return null;
public Void visit(GroupDefinition definition) {
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(definition.getClass().getSimpleName()));
}

@Override
Expand Down Expand Up @@ -4285,20 +4285,20 @@ public Void visit(CallStatement statement) {

@Override
public Void visit(PlaceholderStatement statement) {
throwUnimplemented(statement);
return null;
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(statement.getClass().getSimpleName()));
}

@Override
public Void visit(MacroInstanceStatement statement) {
throwUnimplemented(statement);
return null;
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(statement.getClass().getSimpleName()));
}

@Override
public Void visit(MacroMatchStatement statement) {
throwUnimplemented(statement);
return null;
throw new IllegalStateException(
"No %s should ever reach the Typechecker".formatted(statement.getClass().getSimpleName()));
}

@Override
Expand Down
Loading