viam: Extract Abi.RegisterRef and remove GeneratesRegisterFileName interface#948
Merged
Conversation
github-actions
Bot
added
lcb
Jozott00
force-pushed
the
chore/refactor-abi-def
branch
from
ab373b3 to
0ff2bb9
Compare
Use @nullable instead
This allows the UME definition to reuse the generic `RegisterRef` record.
Jozott00
force-pushed
the
chore/refactor-abi-def
branch
from
0ff2bb9 to
2890293
Compare
Contributor
Author
|
@arcane-quill this PR will allow you to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts most of the
Abi.RegisterReftovadl.viam.RegisterRef, so the datastructure can be reused in other definitions like the UME (#834).Additionally, it removes the
GeneratesRegisterFileNamewhich does not fit into the VIAM hierarchy and is already covered by theRegisterResourceclass.