iss: Implement PC annotations [current], [next] and [next next]#951
Draft
BadGraphixD wants to merge 2 commits into
Draft
iss: Implement PC annotations [current], [next] and [next next]#951BadGraphixD wants to merge 2 commits into
BadGraphixD wants to merge 2 commits into
Conversation
- Register aliases cannot point to pc aliases - Added register suggestions to register alias diagnostics - Added unit tests
github-actions
Bot
added
enhancement
Contributor
Author
|
@flofriday could you please review the first commit. Since I already merged #932, your requested changes from that review are here. |
- Implemented `[current]`, `[next]` and `[next next]` on pc and alias pc definitions - The pc subcalls (like `.current`) overrule the annotations - Added tests
flofriday
reviewed
May 13, 2026
| error("Unknown alias source register", targetIdent.location()) | ||
| .locationDescription(targetIdent.location(), "Unknown register `%s`.", | ||
| targetIdent) | ||
| .suggestions(suggestions) |
Contributor
There was a problem hiding this comment.
praise: Awesome, thank you :)
Contributor
Honestly, that whole situation is on me, I've wrote that review before you merged but forgot to submit it on the previous PR 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[current],[next]and[next next]on pc and alias pc definitions.current) overrule the annotations