Skip to content

Commit dc5baf8

Browse files
d12fkcron2
authored andcommitted
iservice: fix off by one error
In case there is more than one non-ignored interface domain, the start of the next domain was off by one glyph. That meant that all but the first domain was ignored when converting to MULTI_SZ. Reported-by: Marc Heuse <marc@srlabs.de> Reported-by: stephan@srlabs.de Change-Id: I3ebf30f6d9edc66eb54fb3f1b5634c96d156b1ca Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> Acked-by: Gert Doering <gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1395 Message-Id: <20251126104938.5612-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34678.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
1 parent c0cb510 commit dc5baf8

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/openvpnserv/interactive.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2234,7 +2234,8 @@ GetItfDnsDomains(HKEY itf, PCWSTR search_domains, PWSTR domains, PDWORD size)
22342234
return NO_ERROR;
22352235
}
22362236

2237-
pos = comma + 1;
2237+
/* Comma pos is now +1 after adding leading dot */
2238+
pos = comma + 2;
22382239
}
22392240
}
22402241
}

0 commit comments

Comments
 (0)