loadtest-controller: throw exception instead of System.exit(1) on errors

Author: ivchicano

loadtest-controller/src/main/java/io/openvidu/loadtest/exceptions/LoadTestInitializationException.java

@@ -0,0 +1,12 @@
+package io.openvidu.loadtest.exceptions;
+
+public class LoadTestInitializationException extends RuntimeException {
+
+    public LoadTestInitializationException(String message) {
+        super(message);
+    }
+
+    public LoadTestInitializationException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

loadtest-controller/src/main/java/io/openvidu/loadtest/monitoring/ElasticSearchClient.java

@@ -28,6 +28,7 @@
 import com.fasterxml.jackson.databind.JsonNode;
 
 import io.openvidu.loadtest.config.LoadTestConfig;
+import io.openvidu.loadtest.exceptions.LoadTestInitializationException;
 
 @Service
 public class ElasticSearchClient {
@@ -81,9 +82,11 @@ public void init() {
                 log.info("Connection to Elasticsearch established at {}", elasticsearchHost);
             }
         } catch (Exception e) {
-            log.error("Failed to initialize Elasticsearch client: {}", e.getMessage());
-            log.error(
-                    "If property 'ELASTICSEARCH_HOST' is defined, then it is mandatory that OpenVidu Load Test is able to connect to it");
+            throw new LoadTestInitializationException(
+                    "Connection to Elasticsearch failed at " + loadTestConfig.getElasticsearchHost()
+                            + " (" + e.getMessage()
+                            + "). If property 'ELASTICSEARCH_HOST' is defined, then it is mandatory that OpenVidu Load Test is able to connect to it",
+                    e);
         }
     }
 
@@ -93,11 +96,11 @@ private boolean doPing() {
             BooleanResponse response = this.client.ping();
             pingSuccess = response.value();
         } catch (IOException e) {
-            log.error("Connection to Elasticsearch failed at {} ({})", loadTestConfig.getElasticsearchHost(),
-                    e.getMessage());
-            log.error(
-                    "If property 'ELASTICSEARCH_HOST' is defined, then it is mandatory that OpenVidu Load Test is able to connect to it");
-            System.exit(1);
+            throw new LoadTestInitializationException(
+                    "Connection to Elasticsearch failed at " + loadTestConfig.getElasticsearchHost()
+                            + " (" + e.getMessage()
+                            + "). If property 'ELASTICSEARCH_HOST' is defined, then it is mandatory that OpenVidu Load Test is able to connect to it",
+                    e);
         }
         return pingSuccess;
     }

loadtest-controller/src/main/java/io/openvidu/loadtest/services/Ec2Client.java

@@ -36,6 +36,7 @@
 import software.amazon.awssdk.services.ec2.model.InstanceState;
 
 import io.openvidu.loadtest.config.LoadTestConfig;
+import io.openvidu.loadtest.exceptions.LoadTestInitializationException;
 import io.openvidu.loadtest.models.testcase.WorkerType;
 
 @Service
@@ -86,9 +87,9 @@ public void init() {
                     .credentialsProvider(StaticCredentialsProvider.create(awsCreds))
                     .build();
         } else {
-            log.error("AWS credentials are empty in application.properties");
             if (this.loadTestConfig.getWorkerUrlList().isEmpty()) {
-                System.exit(0);
+                throw new LoadTestInitializationException(
+                        "No workers or AWS credentials provided. Please provide at least one of them to run the load test");
             }
         }
     }