browser-emulator: stop and remove ffmpeg container when removing participant

Author: ivchicano

browser-emulator/src/services/browser/emulated/emulated-browser.service.ts

@@ -13,6 +13,7 @@ interface EmulatedContainerInfo {
 	containerId: string;
 	sessionName: string;
 	userName: string;
+	ffmpegContainerName?: string;
 	createdAt: Date;
 }
 
@@ -111,6 +112,11 @@ export class EmulatedBrowserService {
 			containerId,
 			sessionName,
 			userName: userId,
+			ffmpegContainerName:
+				properties.role === Role.PUBLISHER &&
+				(properties.video || properties.audio)
+					? ffmpegContainerName
+					: undefined,
 			createdAt: new Date(),
 		});
 
@@ -258,6 +264,21 @@ export class EmulatedBrowserService {
 			return;
 		}
 
+		// Stop ffmpeg container if present
+		if (containerInfo.ffmpegContainerName) {
+			try {
+				await this.dockerService.stopContainer(
+					containerInfo.ffmpegContainerName,
+				);
+			} catch (error) {
+				console.error(
+					`Error stopping ffmpeg container ${containerInfo.ffmpegContainerName} for ${connectionId}:`,
+					error,
+				);
+			}
+		}
+
+		// Stop join container
 		try {
 			await this.dockerService.stopContainer(containerInfo.containerId);
 		} catch (error) {

browser-emulator/tests/unit/emulated-browser.service.test.ts

@@ -203,6 +203,14 @@ describe('EmulatedBrowserService', () => {
 			await service.deleteStreamManagerWithConnectionId(connectionId);
 
 			expect(mockDockerService.stopContainer).toHaveBeenCalled();
+			// Ensure ffmpeg container was also stopped
+			expect(mockDockerService.stopContainer).toHaveBeenCalledWith(
+				expect.stringContaining('ffmpeg-emulated-'),
+			);
+			// Ensure join container (startContainer return value) was stopped
+			expect(mockDockerService.stopContainer).toHaveBeenCalledWith(
+				'container-id-123',
+			);
 			expect(mockDockerService.removeContainer).toHaveBeenCalled();
 		});
 	});
@@ -231,6 +239,9 @@ describe('EmulatedBrowserService', () => {
 			);
 
 			expect(mockDockerService.stopContainer).toHaveBeenCalled();
+			expect(mockDockerService.stopContainer).toHaveBeenCalledWith(
+				expect.stringContaining('ffmpeg-emulated-'),
+			);
 			// Verify container is no longer tracked
 			expect(
 				service.getParticipantContainerId(connectionId),
@@ -268,6 +279,9 @@ describe('EmulatedBrowserService', () => {
 			await service.clean();
 
 			expect(mockDockerService.stopContainer).toHaveBeenCalled();
+			expect(mockDockerService.stopContainer).toHaveBeenCalledWith(
+				expect.stringContaining('ffmpeg-emulated-'),
+			);
 			// Verify container is no longer tracked
 			expect(
 				service.getParticipantContainerId(connectionId),