fix(security): 2 improvements across 2 files#898
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Cross-Site Scripting (XSS) in Chat Messages - Security: Missing rel="noopener noreferrer" on external links (Tabnabbing) Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Cross-Site Scripting (XSS) in Chat Messages - Security: Missing rel="noopener noreferrer" on external links (Tabnabbing) Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:openvidu-components-angular/projects/openvidu-components-angular/src/lib/components/panel/chat-panel/chat-panel.component.html:L28Chat messages are rendered using [innerHTML] with the linkify pipe, allowing users to inject arbitrary HTML/JavaScript. The Linkifier uses Autolinker which converts URLs to clickable links, but doesn't sanitize the original message content.
Solution
Use Angular's DomSanitizer to sanitize the message content before rendering, or use [textContent] instead of [innerHTML] and implement safe linkification separately.
Changes
openvidu-components-angular/projects/openvidu-components-angular/src/lib/components/panel/chat-panel/chat-panel.component.html(modified)openvidu-components-angular/projects/openvidu-components-angular/src/lib/pipes/translate.pipe.ts(modified)