Skip to content

fix: guard AdminPHAL validator.validate so a raising validator skips the plugin#93

Merged
JarbasAl merged 1 commit into
devfrom
fix/admin-validator-guard
Jun 20, 2026
Merged

fix: guard AdminPHAL validator.validate so a raising validator skips the plugin#93
JarbasAl merged 1 commit into
devfrom
fix/admin-validator-guard

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Closes #92.

PHAL.load_plugins (service.py:80-85) wraps validator.validate() in try/except; AdminPHAL.load_plugins (admin.py:58) did not, so a raising validator aborted loading of all remaining admin plugins. This mirrors the service.py guard (log + skip the plugin).

Found during a source-validation pass of the OVOS Technical Manual.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d01fb0cc-6a77-4d3e-808e-014b868fca80

📥 Commits

Reviewing files that changed from the base of the PR and between a9e68ae and 90b3c30.

📒 Files selected for processing (1)
  • ovos_PHAL/admin.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/admin-validator-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the fix label Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

I've completed the automated review of your changes. 📑

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

A detailed health report for the project. 📝

✅ All required files present.

Latest Version: 0.2.14a1

ovos_PHAL/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_PHAL/version.py has valid version block markers

🏷️ Release Preview

A sneak peek at the impact of your contribution. 🌟

Current: 0.2.14a1Next: 0.2.15a1

Signal Value
Label (none)
PR title fix: guard AdminPHAL validator.validate so a raising validator skips the plugin
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.2.15a1

Channel Status Note Current Constraint
Stable Compatible ovos-PHAL>=0.2.10,<0.3.0
Testing Compatible ovos-phal>=0.2.11,<1.0.0
Alpha Compatible ovos-phal>=0.2.14a1

📊 Coverage

How well do we know our own code? 🧠

35.3% total coverage

Per-file coverage (6 files)
File Coverage Missing lines
ovos_PHAL/__main__.py 0.0% 11
ovos_PHAL/detection.py 0.0% 44
ovos_PHAL/version.py 0.0% 7
ovos_PHAL/admin.py 30.0% 35
ovos_PHAL/service.py 68.1% 22
ovos_PHAL/__init__.py 100.0% 0

Full report: download the coverage-report artifact.

🔒 Security (pip-audit)

Ensuring our security logs are being captured. 🪵

✅ No known vulnerabilities found (60 packages scanned).

🔍 Lint

Just keeping you informed on the state of things. ℹ️

ruff: issues found — see job log

⚖️ License Check

I've checked the license history of this repo. 📜

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔌 Plugin Detection

I've checked the plugin's 'logging' output. 🪵

ℹ️ Not an OVOS plugin — OPM check skipped.

🔨 Build Tests

A thorough inspection of the build process. 🔍

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

May your merges be conflict-free! 🕊️

@JarbasAl JarbasAl marked this pull request as ready for review June 20, 2026 22:34
@JarbasAl JarbasAl merged commit 438dbac into dev Jun 20, 2026
16 checks passed
@JarbasAl JarbasAl deleted the fix/admin-validator-guard branch June 20, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdminPHAL.load_plugins runs validator.validate() unguarded; a raising validator crashes admin plugin loading

1 participant