fix: guard AdminPHAL validator.validate so a raising validator skips the plugin#93
Conversation
|
Warning Review limit reached
More reviews will be available in 44 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I've completed the automated review of your changes. 📑I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthA detailed health report for the project. 📝 ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewA sneak peek at the impact of your contribution. 🌟 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
📊 CoverageHow well do we know our own code? 🧠 ❌ 35.3% total coverage Per-file coverage (6 files)
Full report: download the 🔒 Security (pip-audit)Ensuring our security logs are being captured. 🪵 ✅ No known vulnerabilities found (60 packages scanned). 🔍 LintJust keeping you informed on the state of things. ℹ️ ❌ ruff: issues found — see job log ⚖️ License CheckI've checked the license history of this repo. 📜 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔌 Plugin DetectionI've checked the plugin's 'logging' output. 🪵 ℹ️ Not an OVOS plugin — OPM check skipped. 🔨 Build TestsA thorough inspection of the build process. 🔍 ✅ All versions pass
May your merges be conflict-free! 🕊️ |
Closes #92.
PHAL.load_plugins(service.py:80-85) wrapsvalidator.validate()in try/except;AdminPHAL.load_plugins(admin.py:58) did not, so a raising validator aborted loading of all remaining admin plugins. This mirrors the service.py guard (log + skip the plugin).Found during a source-validation pass of the OVOS Technical Manual.