Skip to content

fix: guard AdminPHAL validator.validate so a raising validator skips the plugin #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarbasAl merged 1 commit into from
Jun 20, 2026
Merged

fix: guard AdminPHAL validator.validate so a raising validator skips the plugin #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ovos_PHAL/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from ovos_plugin_manager.phal import find_admin_plugins
from ovos_utils import wait_for_exit_signal
from ovos_config import Configuration

Check failure on line 3 in ovos_PHAL/admin.py

View workflow job for this annotation

GitHub Actions / lint / lint

ruff (F401) 

ovos_PHAL/admin.py:3:25: F401 `ovos_config.Configuration` imported but unused
  help: Remove unused import: `ovos_config.Configuration`
from ovos_utils.log import LOG, init_service_logger

from ovos_PHAL import PHAL
Expand Down Expand Up @@ -55,7 +55,11 @@
if not enabled:
continue # require explicit enabling by user
if hasattr(plug, "validator"):
enabled = plug.validator.validate(config)
try:
enabled = plug.validator.validate(config)
except Exception:
LOG.exception(f"Validator failed for PHAL plugin: {name}")
continue

if enabled:
try:
Expand Down
Loading