Skip to content

Commit 5b41560

Browse files
JarbasAlclaude
andcommitted
fix(test): patch _locale.voc_match/voc_list, not svc directly
StopService no longer inherits OVOSAbstractApplication; vocabulary matching is delegated to self._locale (LocaleResources). Tests in TestStop1Draining that patched svc.voc_match/voc_list directly now patch svc._locale instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 444133c commit 5b41560

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

test/unittests/test_stop_service.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ def test_match_high_multi_pong_selects_most_recent(self):
640640
{"skill_id": "new_skill", "activated_at": 500.0},
641641
]
642642
self.svc.bus.once = MagicMock()
643-
with patch.object(self.svc, "voc_match",
643+
with patch.object(self.svc._locale, "voc_match",
644644
side_effect=lambda utt, voc, lang, exact: voc == "stop"), \
645645
patch.object(StopService, "get_active_skills",
646646
return_value=["new_skill", "old_skill"]), \
@@ -663,7 +663,7 @@ def test_targeted_stop_removes_only_target_from_active_handlers(self):
663663
{"skill_id": "target_skill", "activated_at": 500.0},
664664
]
665665
self.svc.bus.once = MagicMock()
666-
with patch.object(self.svc, "voc_match",
666+
with patch.object(self.svc._locale, "voc_match",
667667
side_effect=lambda utt, voc, lang, exact: voc == "stop"), \
668668
patch.object(StopService, "get_active_skills",
669669
return_value=["target_skill", "keep_skill"]), \
@@ -683,7 +683,7 @@ def test_targeted_stop_clears_target_response_mode_only(self):
683683
sess.active_handlers = [{"skill_id": "target_skill", "activated_at": 500.0}]
684684
sess.set_response_mode("target_skill", 9999999999.0)
685685
self.svc.bus.once = MagicMock()
686-
with patch.object(self.svc, "voc_match",
686+
with patch.object(self.svc._locale, "voc_match",
687687
side_effect=lambda utt, voc, lang, exact: voc == "stop"), \
688688
patch.object(StopService, "get_active_skills",
689689
return_value=["target_skill"]), \
@@ -706,7 +706,7 @@ def test_global_stop_drains_both_lists_and_response_mode(self):
706706
sess.active_skills = [["a", 1.0]]
707707
sess.set_response_mode("c", 9999999999.0)
708708

709-
with patch.object(self.svc, "voc_match",
709+
with patch.object(self.svc._locale, "voc_match",
710710
side_effect=lambda utt, voc, lang, exact: voc == "global_stop"), \
711711
patch.object(StopService, "get_active_skills", return_value=["a"]), \
712712
patch("ovos_core.intent_services.stop_service.SessionManager.get",
@@ -730,7 +730,7 @@ def test_global_stop_no_positive_pong_drains_session(self):
730730
sess.set_response_mode("a", 9999999999.0)
731731

732732
self.svc.config = {"min_conf": 0.5}
733-
with patch.object(self.svc, "voc_list", return_value=["stop"]), \
733+
with patch.object(self.svc._locale, "voc_list", return_value=["stop"]), \
734734
patch("ovos_core.intent_services.stop_service.match_one",
735735
return_value=("stop", 0.9)), \
736736
patch.object(StopService, "get_active_skills", return_value=["a"]), \

0 commit comments

Comments
 (0)