test: verify skill install from ggwave audio end-to-end by JarbasAl · Pull Request #770 · OpenVoiceOS/ovos-core

JarbasAl · 2026-06-22T19:08:33Z

What

Add an end-to-end test (test/end2end/test_ggwave_skill_install.py) proving the data-over-sound skill-install path: a genuine ggwave waveform carrying a GHS: (GitHub-skill) payload installs a skill through ovos-core's SkillsStore.

How

Wires the real ggwave audio transformer plugin and SkillsStore onto a single bus, feeds a real ggwave waveform, and asserts the decoded payload drives ovos.skills.install → pip_install(["git+https://github.com/OpenVoiceOS/skill-hello-world"]) → ovos.skills.install.complete. pip_install and GitHub validation are mocked, so nothing is fetched or installed. Also asserts the allow_pip=false path refuses the install.

Changes

New e2e test (2 cases).
test extra: add ovos-dinkum-listener and ovos-audio-transformer-plugin-ggwave; bump ovoscope floor to >=0.20.0 for feed_audio_stream.

Dependency ordering

Depends on the ovoscope streaming PR (OpenVoiceOS/ovoscope#86) and the ggwave plugin decode-in-pipeline PR (OpenVoiceOS/ovos-audio-transformer-plugin-ggwave#42) being released first; CI here goes green once those land.

Test plan

uv run pytest test/end2end/test_ggwave_skill_install.py -v — 2 passed locally.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Added end-to-end coverage for voice-driven skill installation using audio input.
- Verified installation success feedback and failure handling when package installs are disabled.
Chores
- Updated test dependencies to include audio/voice components needed for the new installation flow validation.

coderabbitai · 2026-06-22T19:08:42Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 74c070d0-8fee-40f1-99f9-5b55a7cf7ecd

📥 Commits

Reviewing files that changed from the base of the PR and between ad67abd and 0204fc5.

📒 Files selected for processing (2)

pyproject.toml
test/end2end/test_ggwave_skill_install.py

📝 Walkthrough

Walkthrough

This PR adds two test-only dependencies (ovos-dinkum-listener, ovos-audio-transformer-plugin-ggwave) to pyproject.toml and introduces a new end-to-end test file validating that ggwave-encoded audio payloads trigger skill installation through SkillsStore, including a pip-disabled failure scenario.

Changes

GGWave skill install test coverage

Layer / File(s)	Summary
Test dependencies `pyproject.toml`	Adds `ovos-dinkum-listener` and `ovos-audio-transformer-plugin-ggwave` to the `test` optional-dependencies list.
Audio encoding helper and test setup `test/end2end/test_ggwave_skill_install.py`	Adds module docstring, `PLUGIN_NAME`/`GGWAVE_RATE` constants, `_ggwave_audio` helper for encoding/resampling PCM audio, and `TestGGWaveSkillInstall.setUp`/`tearDown` wiring real `GGWavePlugin` and `SkillsStore` on a shared bus with mocked `pip_install`/`validate_skill`.
Install flow test cases `test/end2end/test_ggwave_skill_install.py`	Adds `test_ghs_audio_triggers_skill_install` verifying install request/completion events, and `test_install_blocked_when_pip_disabled` verifying blocked installs emit failure events; adds `unittest.main()` entry point.

Estimated code review effort: 2 (Simple) | ~12 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Test as TestGGWaveSkillInstall
  participant GGWavePlugin
  participant Bus
  participant SkillsStore

  Test->>GGWavePlugin: feed encoded GHS audio stream
  GGWavePlugin->>Bus: emit decoded GHS payload
  Bus->>SkillsStore: ovos.skills.install request
  SkillsStore->>SkillsStore: pip_install (mocked)
  SkillsStore->>Bus: ovos.skills.install.complete or .failed
  Bus->>Test: assert emitted messages

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/ggwave-skill-install-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-06-22T19:09:38Z

I've finished my rounds! Here's the state of the PR. 🏥

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

Keeping the project in tip-top shape! 🏃

✅ All required files present.

Latest Version: 2.1.6a1

✅ ovos_core/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ ovos_core/version.py has valid version block markers

🏷️ Release Preview

I've checked the 'New Features' highlight reel. 📽️

Current: 2.5.0a1 → Next: 2.5.0a2

Signal	Value
Label	(none)
PR title	`test: verify skill install from ggwave audio end-to-end`
Bump	alpha

✅ PR title follows conventional commit format.

🚀 Release Channel Compatibility

Predicted next version: 2.5.0a2

Channel	Status	Note	Current Constraint
Stable	❌	Too new (must be <1.4.0)	`ovos-core>=1.3.1,<1.4.0`
Testing	✅	Compatible	`ovos-core>=2.1.1,<3.0.0`
Alpha	✅	Compatible	`ovos-core>=2.2.4a1`

🌍 Locale Build

The latest check report is officially filed. 📁

✅ Locale properly configured (64 files, 17 languages)

Locale directories found:

ovos_core/intent_services/locale

Localization coverage:

ovos_core/intent_services/locale: 64 files in 17 languages (eu-ES, es-es, it-it, de-de, uk-ua...)

pyproject.toml: ✅ [tool.setuptools.package-data.ovos_core] includes locale

intent_services/locale/*/*.voc

Build manifest: ✅ 31 locale files included in package

🔒 Security (pip-audit)

Checking for any digital cooties in your dependencies... 👾

✅ No known vulnerabilities found (110 packages scanned).

🔨 Build Tests

The build process has successfully terminated. 🏁

✅ All versions pass

Python	Build	Install	Tests
3.10	✅	✅	✅
3.11	✅	✅	✅
3.12	✅	✅	✅
3.13	✅	✅	✅
3.14	✅	✅	✅

⚖️ License Check

Ensuring our EULA (if any) is still valid. 📑

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

📚 Docs

Processing complete! Details follow. 📬

✅ All required documentation files present.

✅ README.md

🔎 Type Check

Another piece of the puzzle! 🧩

❌ mypy: 272 error(s) found

ovos_core/main.py:24:1: error: Skipping analyzing "ovos_utils.log": module is installed, but missing library stubs or py.typed marker [import-untyped]

Errors (showing first 10/272)

test/unittests/test_skill/__init__.py:15:1: error: Skipping analyzing "ovos_workshop.skills.ovos": module is installed, but missing library stubs or py.typed marker  [import-untyped]
test/end2end/conftest.py:10:1: error: Cannot find implementation or library stub for module named "pytest"  [import-not-found]
ovos_core/transformers.py:2:1: error: Skipping analyzing "ovos_config": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:3:1: error: Skipping analyzing "ovos_plugin_manager.intent_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:4:1: error: Skipping analyzing "ovos_plugin_manager.metadata_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:5:1: error: Skipping analyzing "ovos_plugin_manager.text_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:7:1: error: Skipping analyzing "ovos_plugin_manager.templates.pipeline": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:8:1: error: Skipping analyzing "ovos_utils.json_helper": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:9:1: error: Skipping analyzing "ovos_utils.log": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:16:9: error: Need type annotation for "loaded_plugins" (hint: "loaded_plugins: dict[<type>, <type>] = ...")  [var-annotated]

📊 Coverage

Measuring the safety net for your changes. 🥅

⚠️ 63.6% total coverage

Files below 80% coverage (9 files)

File	Coverage	Missing lines
`ovos_core/__init__.py`	0.0%	7
`ovos_core/__main__.py`	0.0%	26
`ovos_core/intent_services/__init__.py`	0.0%	1
`ovos_core/version.py`	0.0%	18
`ovos_core/skill_installer.py`	42.3%	139
`ovos_core/intent_services/service.py`	49.7%	184
`ovos_core/skill_manager.py`	58.8%	173
`ovos_core/transformers.py`	66.0%	49
`ovos_core/intent_services/dispatcher.py`	73.4%	29

Full report: download the coverage-report artifact.

🔌 Plugin Detection

Auditing the plugin's registration and metadata. 📝

⚠️ Plugin Status: WARNINGS (2)

Plugin Info:

Name: ovos-core
Description: The spiritual successor to Mycroft AI, OVOS is flexible voice assistant software that can be run almost anywhere!

OPM Detection:

Plugin Type	Wheel	Editable
pipeline	✅	✅

Entry Point Validation:

Entry Point	Type	Import	Interface
`ovos-converse-pipeline-plugin`	pipeline	✅ 17ms	⊘
`ovos-fallback-pipeline-plugin`	pipeline	✅ 1ms	⊘
`ovos-stop-pipeline-plugin`	pipeline	✅ 45ms	⊘

⊘ No settingsmeta.json
✅ requires-python >=3.10 — running Python 3.11

Issues:

⚠️ No settingsmeta.json found
⚠️ No settingsmeta.json found

🔌 Skill Tests (ovoscope)

I've verified the skill's 'GUI' elements are responsive. 🖼️

✅ 4/38 passed

❌ **TestAdaptIntent** — 0/4

Test	Result
`test_skill_blacklist`	❌ subtests passed
`test_padatious_no_match`	❌ subtests passed
`test_adapt_match`	❌ subtests passed
`test_intent_blacklist`	❌ subtests passed

test_skill_blacklist failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_padatious_no_match failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_adapt_match failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestCancelIntentMidSentence** — 0/1

Test	Result
`test_cancel_match`	❌ subtests passed

test_cancel_match failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestConverse** — 0/1

Test	Result
`test_parrot_mode`	❌ subtests passed

test_parrot_mode failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestCountSkills** — 0/4

Test	Result
`test_count_infinity_stop_low`	❌ subtests passed
`test_count_infinity_global`	❌ subtests passed
`test_count`	❌ subtests passed
`test_count_infinity_active`	❌ subtests passed

test_count_infinity_stop_low failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_count_infinity_global failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_count failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestDeactivate** — 2/3

Test	Result
`test_deactivate_inside_converse`	❌ subtests passed
`test_activate`	✅ passed
`test_deactivate`	✅ passed

test_deactivate_inside_converse failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestFallback** — 0/1

Test	Result
`test_fallback_match`	❌ subtests passed

test_fallback_match failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

✅ **TestGGWaveSkillInstall** — 2/2

❌ **TestGlobalStopVocWithActiveSkill** — 0/1

Test	Result
`test_global_stop_voc_with_active_skill`	❌ subtests passed

test_global_stop_voc_with_active_skill failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestGlobalStopVocabulary** — 0/2

Test	Result
`test_global_stop_voc_no_active_skills`	❌ subtests passed
`test_stop_voc_exact_still_works`	❌ subtests passed

test_global_stop_voc_no_active_skills failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_stop_voc_exact_still_works failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestIntentPipelineRouting** — 0/4

Test	Result
`test_padatious_intent_matched`	❌ subtests passed
`test_high_priority_stage_handles_before_low`	❌ subtests passed
`test_no_match_produces_intent_failure`	❌ subtests passed
`test_blacklisted_skill_falls_through_to_failure`	❌ subtests passed

test_padatious_intent_matched failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_high_priority_stage_handles_before_low failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_no_match_produces_intent_failure failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestLangDisambiguation** — 0/4

Test	Result
`test_lang_text_detection`	❌ subtests passed
`test_stt_lang`	❌ subtests passed
`test_invalid_lang_detection`	❌ subtests passed
`test_metadata_preferred_over_text_detection`	❌ subtests passed

test_lang_text_detection failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_stt_lang failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_invalid_lang_detection failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestNoSkills** — 0/2

Test	Result
`test_routing`	❌ subtests passed
`test_complete_failure`	❌ subtests passed

test_routing failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_complete_failure failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestPadatiousIntent** — 0/4

Test	Result
`test_adapt_no_match`	❌ subtests passed
`test_intent_blacklist`	❌ subtests passed
`test_skill_blacklist`	❌ subtests passed
`test_padatious_match`	❌ subtests passed

test_adapt_no_match failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_intent_blacklist failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_skill_blacklist failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopNoSkills** — 0/3

Test	Result
`test_not_exact_med`	❌ subtests passed
`test_not_exact_high`	❌ subtests passed
`test_exact`	❌ subtests passed

test_not_exact_med failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_not_exact_high failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_exact failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopServiceNotASkill** — 0/1

Test	Result
`test_stop_service_is_not_a_skill`	❌ subtests passed

test_stop_service_is_not_a_skill failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopSkillCanHandleFalse** — 0/1

Test	Result
`test_stop_with_active_skill_ping_pong`	❌ subtests passed

test_stop_with_active_skill_ping_pong failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

🚌 Bus Coverage

A forensic look at what's being emitted. 🔎

🔴 Coverage Summary

Metric	Status	Coverage
Listeners	`██░░░░░░░░` 23.4%	51/218 handlers
Emitters	`██████████` 100%	24/24 observed
Assertions	`██████████` 100%	24/24 asserted

📊 Per-Skill Breakdown

Skill	Listeners	Observed	Asserted
`AdaptPipeline`	4/14 (28.6%)	0/0	0/0
`ConverseService`	0/4 (0.0%)	0/0	0/0
`DomainAdaptPipeline`	4/14 (28.6%)	0/0	0/0
`FallbackService`	4/4 (100.0%)	0/0	0/0
`HierarchicalAdaptPipeline`	4/14 (28.6%)	0/0	0/0
`IntentDispatcher`	1/2 (50.0%)	0/0	0/0
`IntentManifest`	0/8 (0.0%)	0/0	0/0
`IntentService`	2/4 (50.0%)	0/0	0/0
`Model2VecIntentPipeline`	3/12 (25.0%)	0/0	0/0
`Model2VecPrototypePipeline`	3/12 (25.0%)	0/0	0/0
`PadaciosoPipeline`	2/11 (18.2%)	0/0	0/0
`PadatiousPipeline`	4/15 (26.7%)	0/0	0/0
`SkillManager`	0/4 (0.0%)	0/0	0/0
`StopService`	2/2 (100.0%)	0/0	0/0
`__core__`	8/29 (27.6%)	12/12	12/12
`ovos-skill-count.openvoiceos`	4/20 (20.0%)	0/0	0/0
`ovos-skill-fallback-unknown.openvoiceos`	3/21 (14.3%)	4/4	4/4
`ovos-skill-hello-world.openvoiceos`	1/24 (4.2%)	0/0	0/0
`stop.openvoiceos`	0/0 (0.0%)	8/8	8/8
`type`	2/4 (50.0%)	0/0	0/0

🔍 Detailed Message Type Breakdown

`AdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ intent.service.adapt.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ intent.service.adapt.manifest.get (442x)
✅ register_intent (68x)
✅ register_vocab (1339x)

`ConverseService`

⚠️ Uncovered Listeners:

❌ converse:skill (Intent)
❌ intent.service.active_skills.get
❌ intent.service.skills.activate
❌ intent.service.skills.deactivate

`DomainAdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ intent.service.adapt.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ intent.service.adapt.manifest.get (442x)
✅ register_intent (68x)
✅ register_vocab (1339x)

`FallbackService`

✅ Covered Listeners:

✅ ovos.skills.fallback.deregister (49x)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.response (3x)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.start (3x)
✅ ovos.skills.fallback.register (27x)

`HierarchicalAdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ intent.service.adapt.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ intent.service.adapt.manifest.get (442x)
✅ register_intent (68x)
✅ register_vocab (1339x)

`IntentDispatcher`

⚠️ Uncovered Listeners:

❌ mycroft.skill.handler.error
✅ Covered Listeners:
✅ mycroft.skill.handler.complete (62x)

`IntentManifest`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.describe (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.list (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ ovos.intent.register.template (Intent)
❌ ovos.skill.deregister

`IntentService`

⚠️ Uncovered Listeners:

❌ intent.service.intent.get (Intent)
❌ intent.service.skills.deactivate
✅ Covered Listeners:
✅ intent.service.pipelines.reload (105x)
✅ ovos.utterance.handle (64x)

`Model2VecIntentPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ detach_intent
❌ mycroft.ready
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ padatious:register_intent (112x)
✅ register_intent (68x)

`Model2VecPrototypePipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ detach_intent
❌ mycroft.ready
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ padatious:register_intent (112x)
✅ register_intent (68x)

`PadaciosoPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ padatious:register_entity (Intent)
❌ detach_intent
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ padatious:register_intent (112x)

`PadatiousPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ padatious:register_entity (Intent)
❌ detach_intent
❌ intent.service.padatious.entities.manifest.get
❌ intent.service.padatious.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
✅ Covered Listeners:
✅ detach_skill (157x)
✅ intent.service.padatious.manifest.get (442x)
✅ mycroft.skills.train (105x)
✅ padatious:register_intent (112x)

`SkillManager`

⚠️ Uncovered Listeners:

❌ skillmanager.activate
❌ skillmanager.deactivate
❌ skillmanager.keep
❌ skillmanager.list

`StopService`

✅ Covered Listeners:

✅ stop:global (18x)
✅ stop:skill (3x)

`core`

⚠️ Uncovered Listeners:

❌ add_context
❌ clear_context
❌ message
❌ mycroft.ovos-skill-count.openvoiceos.all_loaded
❌ mycroft.ovos-skill-count.openvoiceos.is_alive
❌ mycroft.ovos-skill-count.openvoiceos.is_ready
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.all_loaded
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.is_alive
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.is_ready
❌ mycroft.ovos-skill-hello-world.openvoiceos.all_loaded
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_alive
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_ready
❌ ovos-skill-count.openvoiceos.set
❌ ovos-skill-fallback-unknown.openvoiceos.set
❌ ovos-skill-hello-world.openvoiceos.set
❌ ovos.session.sync
❌ ovos.skills.fallback.force_timeout
❌ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos
❌ remove_context
❌ skill.converse.get_response.disable
❌ skill.converse.get_response.enable
✅ Covered Listeners:
✅ ovos-skill-count.openvoiceos.stop.response (6x)
✅ ovos.session.update_default (105x)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.response (24x)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.start (24x)
✅ ovos.skills.fallback.pong (26x)
✅ ovos.utterance.handled (144x)
✅ ovos.utterance.speak (66x)
✅ skill.stop.pong (2x)

📤 Emitters:

✅ mycroft.audio.play_sound (Asserted ✅)
✅ ovos.intent.handler.complete (Asserted ✅)
✅ ovos.intent.handler.start (Asserted ✅)
✅ ovos.intent.matched (Asserted ✅)
✅ ovos.intent.unmatched (Asserted ✅)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.request (Asserted ✅)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.response (Asserted ✅)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.start (Asserted ✅)
✅ ovos.skills.fallback.ping (Asserted ✅)
✅ ovos.utterance.handle (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)
✅ recognizer_loop:utterance (Asserted ✅)

`ovos-skill-count.openvoiceos`

⚠️ Uncovered Listeners:

❌ question:action (Intent)
❌ question:action.ovos-skill-count.openvoiceos (Intent)
❌ question:query (Intent)
❌ homescreen.metadata.get
❌ mycroft.ovos-skill-count.openvoiceos.all_loaded
❌ mycroft.ovos-skill-count.openvoiceos.is_alive
❌ mycroft.ovos-skill-count.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ ovos-skill-count.openvoiceos.converse.get_response
❌ ovos-skill-count.openvoiceos.set
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed
✅ Covered Listeners:
✅ mycroft.stop (18x)
✅ ovos-skill-count.openvoiceos.stop (3x)
✅ ovos-skill-count.openvoiceos.stop.ping (3x)
✅ ovos-skill-count.openvoiceos:count_to_N.intent (14x)

`ovos-skill-fallback-unknown.openvoiceos`

⚠️ Uncovered Listeners:

❌ question:action (Intent)
❌ question:action.ovos-skill-fallback-unknown.openvoiceos (Intent)
❌ question:query (Intent)
❌ homescreen.metadata.get
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.all_loaded
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.is_alive
❌ mycroft.ovos-skill-fallback-unknown.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ ovos-skill-fallback-unknown.openvoiceos.converse.get_response
❌ ovos-skill-fallback-unknown.openvoiceos.set
❌ ovos-skill-fallback-unknown.openvoiceos.stop
❌ ovos-skill-fallback-unknown.openvoiceos.stop.ping
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed
✅ Covered Listeners:
✅ mycroft.stop (18x)
✅ ovos.skills.fallback.ovos-skill-fallback-unknown.openvoiceos.request (27x)
✅ ovos.skills.fallback.ping (27x)

📤 Emitters:

✅ mycroft.skill.handler.complete (Asserted ✅)
✅ mycroft.skill.handler.start (Asserted ✅)
✅ ovos.skills.fallback.pong (Asserted ✅)
✅ ovos.utterance.speak (Asserted ✅)

`ovos-skill-hello-world.openvoiceos`

⚠️ Uncovered Listeners:

❌ ovos-skill-hello-world.openvoiceos:Greetings.intent (Intent)
❌ ovos-skill-hello-world.openvoiceos:HelloWorldIntent (Intent)
❌ ovos-skill-hello-world.openvoiceos:HowAreYou.intent (Intent)
❌ ovos-skill-hello-world.openvoiceos:ThankYouIntent (Intent)
❌ question:action (Intent)
❌ question:action.ovos-skill-hello-world.openvoiceos (Intent)
❌ question:query (Intent)
❌ hello.world
❌ homescreen.metadata.get
❌ mycroft.ovos-skill-hello-world.openvoiceos.all_loaded
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_alive
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ ovos-skill-hello-world.openvoiceos.converse.get_response
❌ ovos-skill-hello-world.openvoiceos.set
❌ ovos-skill-hello-world.openvoiceos.stop
❌ ovos-skill-hello-world.openvoiceos.stop.ping
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed
✅ Covered Listeners:
✅ mycroft.stop (18x)

`stop.openvoiceos`

📤 Emitters:

✅ mycroft.skill.handler.complete (Asserted ✅)
✅ mycroft.skill.handler.start (Asserted ✅)
✅ mycroft.stop (Asserted ✅)
✅ ovos-skill-count.openvoiceos.stop (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)
✅ stop.openvoiceos.activate (Asserted ✅)
✅ stop:global (Asserted ✅)
✅ stop:skill (Asserted ✅)

`type`

⚠️ Uncovered Listeners:

❌ recognizer_loop:record_begin (Intent)
❌ recognizer_loop:record_end (Intent)
✅ Covered Listeners:
✅ recognizer_loop:audio_output_end (64x)
✅ recognizer_loop:audio_output_start (66x)

The automation engine never sleeps. 🚂

Wire the real ggwave audio transformer plugin and SkillsStore onto a single bus and feed a genuine ggwave waveform carrying a GHS: payload; assert the decoded payload drives ovos.skills.install through to a pip install request (pip and GitHub validation mocked). Also assert the allow_pip=false path refuses the install. Adds ovos-dinkum-listener and the ggwave plugin to the test extra and bumps the ovoscope floor to >=0.20.0 for feed_audio_stream. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

JarbasAl force-pushed the test/ggwave-skill-install-e2e branch from 55b1c2e to 0204fc5 Compare July 3, 2026 23:32

JarbasAl marked this pull request as ready for review July 4, 2026 00:02

JarbasAl merged commit 1363726 into dev Jul 4, 2026
18 checks passed

JarbasAl deleted the test/ggwave-skill-install-e2e branch July 4, 2026 00:02

Uh oh!

Uh oh!

Conversation

JarbasAl commented Jun 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Changes

Dependency ordering

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I've finished my rounds! Here's the state of the PR. 🏥

📋 Repo Health

🏷️ Release Preview

🌍 Locale Build

🔒 Security (pip-audit)

🔨 Build Tests

⚖️ License Check

📚 Docs

🔎 Type Check

📊 Coverage

🔌 Plugin Detection

🔌 Skill Tests (ovoscope)

🚌 Bus Coverage

🔴 Coverage Summary

📊 Per-Skill Breakdown

AdaptPipeline

ConverseService

DomainAdaptPipeline

FallbackService

HierarchicalAdaptPipeline

IntentDispatcher

IntentManifest

IntentService

Model2VecIntentPipeline

Model2VecPrototypePipeline

PadaciosoPipeline

PadatiousPipeline

SkillManager

StopService

__core__

ovos-skill-count.openvoiceos

ovos-skill-fallback-unknown.openvoiceos

ovos-skill-hello-world.openvoiceos

stop.openvoiceos

type

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JarbasAl commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

`AdaptPipeline`

`ConverseService`

`DomainAdaptPipeline`

`FallbackService`

`HierarchicalAdaptPipeline`

`IntentDispatcher`

`IntentManifest`

`IntentService`

`Model2VecIntentPipeline`

`Model2VecPrototypePipeline`

`PadaciosoPipeline`

`PadatiousPipeline`

`SkillManager`

`StopService`

`core`

`ovos-skill-count.openvoiceos`

`ovos-skill-fallback-unknown.openvoiceos`

`ovos-skill-hello-world.openvoiceos`

`stop.openvoiceos`

`type`