test(e2e): fix transient test_fallback_match meta mismatch on dev#792
Merged
Conversation
ovos-skill-fallback-unknown's 'unknown' dialog speaks with meta
{dialog, data, skill}; the e2e expected only {skill}, so test_fallback_match
fails on dev independently of any PR. Match the real skill output.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe end-to-end fallback test's expected Fallback Test Assertion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fresh off the press! I've got some check results for you. 🗞️I've aggregated the results of the automated checks for this PR below. 📚 DocsThe data is in, and it's looking interesting! 🧐 ✅ All required documentation files present. ✅ 🔒 Security (pip-audit)I've audited the access control lists. 📋 ✅ No known vulnerabilities found (110 packages scanned). 🌍 Locale BuildChecking the status... yep, it's done! ✅ ✅ Locale properly configured (64 files, 17 languages) Locale directories found:
Localization coverage:
pyproject.toml: ✅
Build manifest: ✅ 31 locale files included in package 📋 Repo HealthThe repo's annual physical is complete! 🩺 ✅ All required files present. Latest Version: ✅ 🔎 Type CheckI've performed a routine sweep of your changes. 🧹 ❌ mypy: 248 error(s) found
Errors (showing first 10/248)📊 CoverageIs the code fully immunized with tests? 💉 Files below 80% coverage (8 files)
Full report: download the 🔨 Build TestsVerifying the structural soundness of your build. 🏗️ ✅ All versions pass
⚖️ License CheckReading the fine print so you don't have to! 🔎 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔌 Skill Tests (ovoscope)I've put the skill through its paces with live intent matching. 🏃 ✅ 2/36 passed ❌ **TestAdaptIntent** — 0/4
❌ **TestCancelIntentMidSentence** — 0/1
❌ **TestConverse** — 0/1
❌ **TestCountSkills** — 0/4
❌ **TestDeactivate** — 2/3
❌ **TestFallback** — 0/1
❌ **TestGlobalStopVocWithActiveSkill** — 0/1
❌ **TestGlobalStopVocabulary** — 0/2
❌ **TestIntentPipelineRouting** — 0/4
❌ **TestLangDisambiguation** — 0/4
❌ **TestNoSkills** — 0/2
❌ **TestPadatiousIntent** — 0/4
❌ **TestStopNoSkills** — 0/3
❌ **TestStopServiceAsSkill** — 0/1
❌ **TestStopSkillCanHandleFalse** — 0/1
🚌 Bus CoverageA forensic look at what's being emitted. 🔎 🔴 Coverage Summary
📊 Per-Skill Breakdown
🔍 Detailed Message Type Breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test/end2end/test_fallback.py::test_fallback_matchfails on dev (and every PRbranched off it, e.g. #787) with:
ovos-skill-fallback-unknownspeaks itsunknowndialog with ametaof{dialog, data, skill}, but the expected speak message only listed{skill}. Thisis a stale test expectation (surfaced once the skill was republished), not a code
regression — hence the "transient" failures across PRs.
Fix
Expect the real speak
meta(dialog: "unknown",data: {},skill: ...). Onetest file; no production change.
🤖 Generated with Claude Code
Summary by CodeRabbit