Add locale resources for location disambiguation and date phrasing#186
Conversation
📝 WalkthroughWalkthroughAdds locale-specific data resource files across three locales (English US, French France, Turkish Turkey) containing static lists of ambiguous location identifiers, current weekend phrases, and non-location time phrases for localization support. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR contains only the locale resource files split out of #185.\n\n#185 now stays focused on the generic runtime changes in |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locale/en-us/non_location_phrases.list`:
- Around line 1-5: The new .list files (non_location_phrases.list,
ambiguous_locations.list, current_weekend_phrases.list) are not being loaded at
runtime because the resource loader in __init__.py only calls find_resource()
for location.rx; update the resource initialization in __init__.py (around the
find_resource()/resource loading block) to call find_resource() (or the same
loading helper) for each of these three filenames so they are
registered/consumed at runtime, or explicitly document that this PR depends on
the runtime patch from PR `#185` and ensure merge order is noted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c1e591b9-1a8c-43be-802f-4eb433fbcab2
📒 Files selected for processing (7)
locale/en-us/ambiguous_locations.listlocale/en-us/current_weekend_phrases.listlocale/en-us/non_location_phrases.listlocale/fr-fr/ambiguous_locations.listlocale/fr-fr/current_weekend_phrases.listlocale/fr-fr/non_location_phrases.listlocale/tr-tr/current_weekend_phrases.list
|
Documented the dependency and merge order in the PR description. This branch stays resource-only by design; the runtime loader lives in #185. |
Summary
Notes
This PR intentionally contains only locale resource files.
It depends on the runtime loader added in #185, which consumes these
.listresources from__init__.py.Expected merge order: