Commit 4e95492
committed
fix: un-xfail intent-layers e2e + harden utterance.handled test, bump pins
Root cause of the intent-layers e2e XFAILs is an upstream regression in
ovos-utils (#393 / 9317a8d): FakeBus.on_message dropped the
'if sess.session_id != "default"' guard that the real
MessageBusClient.on_message still keeps, so the default session is folded
on every received message, wiping every in-place add_context mutation
(intent-layer tokens included). Fixed in OpenVoiceOS/ovos-utils#395.
- test_intent_layers_e2e.py: revert the xfail markers added in this PR;
both tests pass once ovos-utils >= 0.13.3a2 lands.
- test_base.py: replace test_on_event_end_is_intent_still_emits_utterance_handled
(stale vs PIPELINE-1 §9.5) with two deterministic branches:
* _defers_utterance_handled_to_core — modern core (>=2.3.0a1) owns the
end-marker, so workshop must NOT also emit ovos.utterance.handled.
* _emits_utterance_handled_legacy — absent/old core, workshop still emits
(migration-window back-compat). Both monkeypatch _core_owns_utterance_handled.
- pyproject.toml: bump floors to the latest alphas that carry the
singleton-registry SessionManager + §9.5 orchestrator ownership:
ovos-utils >= 0.13.3a2, ovos_bus_client >= 2.6.2a2, ovos-spec-tools >= 1.2.3a1,
ovos-core >= 2.4.0a1 (test), ovos-adapt-parser >= 1.4.2a1 (test).1 parent 2aee2bd commit 4e95492
3 files changed
Lines changed: 36 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
355 | 355 | | |
356 | 356 | | |
357 | 357 | | |
358 | | - | |
359 | | - | |
360 | | - | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
361 | 365 | | |
362 | 366 | | |
363 | 367 | | |
364 | 368 | | |
365 | | - | |
366 | | - | |
367 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
368 | 393 | | |
369 | 394 | | |
370 | 395 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | 180 | | |
186 | 181 | | |
187 | 182 | | |
| |||
238 | 233 | | |
239 | 234 | | |
240 | 235 | | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | 236 | | |
247 | 237 | | |
248 | 238 | | |
| |||
0 commit comments