Problem
The deregister_ocp_keyword method in OVOSCommonPlaybackSkill is currently incomplete and does not properly remove entities from internal data structures (ocp_matchers and _ocp_ents). This could lead to memory leaks as entities accumulate without proper cleanup.
Current Behavior
The method currently only passes without removing entities:
- Entities remain in
ocp_matchers dictionary
- Entities remain in
_ocp_ents dictionary
- No local cleanup is performed
Expected Behavior
The method should properly clean up registered entities from internal data structures, even if upstream deregistration is not yet supported.
Context
This issue was identified during code review of PR #365.
References:
Problem
The
deregister_ocp_keywordmethod inOVOSCommonPlaybackSkillis currently incomplete and does not properly remove entities from internal data structures (ocp_matchersand_ocp_ents). This could lead to memory leaks as entities accumulate without proper cleanup.Current Behavior
The method currently only passes without removing entities:
ocp_matchersdictionary_ocp_entsdictionaryExpected Behavior
The method should properly clean up registered entities from internal data structures, even if upstream deregistration is not yet supported.
Context
This issue was identified during code review of PR #365.
References: