Bugfix Issue #52: explicitly setting ca port and hostname#53
Merged
Conversation
1 task
Member
|
i think this is the wrong place, because there the server is its own ca 🤔 |
Contributor
Author
|
Not sure I understand the issue - isn't that always the case when you enable the CA? Usually I'd even put ca_server and ca_port in main so it applies to both, agent and server actually. EDIT: |
Member
|
my point was more of: if the server is the ca for itself, why specify a ca_server then? but if this is only to get the |
Member
|
@dotconfig404 can you please rebase? then i can approve and merge it. |
rwaffen
approved these changes
Jun 13, 2025
Contributor
Author
|
Thanks :) |
Member
|
nope, thank you! for the bug report and fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issue 52
Suggested simple fix for server.
Maybe set it explicitly in agent section as well, although currently I don't know a specific situation where it's needed, except running the agent via command line. Although in that case you can use the
--ca_serverand--ca_portarguments.