Skip to content

Bugfix Issue #52: explicitly setting ca port and hostname#53

Merged
rwaffen merged 2 commits into
OpenVoxProject:mainfrom
dotconfig404:main
Jun 13, 2025
Merged

Bugfix Issue #52: explicitly setting ca port and hostname#53
rwaffen merged 2 commits into
OpenVoxProject:mainfrom
dotconfig404:main

Conversation

@dotconfig404
Copy link
Copy Markdown
Contributor

As per issue 52

Suggested simple fix for server.

Maybe set it explicitly in agent section as well, although currently I don't know a specific situation where it's needed, except running the agent via command line. Although in that case you can use the --ca_server and --ca_port arguments.

@rwaffen
Copy link
Copy Markdown
Member

rwaffen commented Jun 13, 2025

i think this is the wrong place, because there the server is its own ca 🤔

@dotconfig404
Copy link
Copy Markdown
Contributor Author

dotconfig404 commented Jun 13, 2025

Not sure I understand the issue - isn't that always the case when you enable the CA? Usually I'd even put ca_server and ca_port in main so it applies to both, agent and server actually.

EDIT:
As long as it is placed in the server or main section puppetserver ca will work as intended.

@rwaffen
Copy link
Copy Markdown
Member

rwaffen commented Jun 13, 2025

my point was more of: if the server is the ca for itself, why specify a ca_server then? but if this is only to get the puppetserver ca command to run, i dont mind.

@rwaffen
Copy link
Copy Markdown
Member

rwaffen commented Jun 13, 2025

@dotconfig404 can you please rebase? then i can approve and merge it.

@rwaffen rwaffen merged commit 35b50d9 into OpenVoxProject:main Jun 13, 2025
11 checks passed
@rwaffen rwaffen added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 13, 2025
@dotconfig404
Copy link
Copy Markdown
Contributor Author

Thanks :)

@rwaffen
Copy link
Copy Markdown
Member

rwaffen commented Jun 13, 2025

nope, thank you! for the bug report and fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants