parallel test: change port value to puppet_7_node#61
Merged
sebastianrakel merged 7 commits intoOpenVoxProject:mainfrom Sep 15, 2025
Merged
parallel test: change port value to puppet_7_node#61sebastianrakel merged 7 commits intoOpenVoxProject:mainfrom
sebastianrakel merged 7 commits intoOpenVoxProject:mainfrom
Conversation
This the past, the different jobs had filters and were only executed when specific files changed. This is error prone because we potentially forget to enable tests for specific changes. Since we've enough concurrent runners, we can run all jobs always.
The group within the github image is `runner`, not `docker`.
-rc* makes the windows tests fail: ``` System.ArgumentException: The 'ModuleVersion' member is not valid in the module manifest file 'D:\a\openbolt\openbolt\pwsh_module\PuppetBolt\PuppetBolt.psd1': Cannot convert value "5.0.0-rc2" to type "System.Version". Error: "The input string '0-rc2' was not in a correct format." at <ScriptBlock>, D:\a\openbolt\openbolt\pwsh_module\autogenerated.tests.ps1: line 1 at <ScriptBlock>, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 3090 at Invoke-File, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 3099 at Invoke-BlockContainer, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 3008 at Discover-Test, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 1480 at Invoke-Test, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 2474 at Invoke-Pester<End>, C:\Users\runneradmin\Documents\PowerShell\Modules\Pester\5.7.1\Pester.psm1: line 4960 at <ScriptBlock>, D:\a\_temp\c04d9e53-3555-4e44-855d-5de95da6a5f0.ps1: line 2 at <ScriptBlock>, <No file>: line 1 ```
We have a test that verifies all the parameters that bolt subcommands offer in powershell. Besides the bolt-provided parameters, Powershell adds own/internals parameters as well. Powershell 7.5 introduced a new parameter, ProgressAction, which we need to add to the exclude list. https://learn.microsoft.com/de-de/powershell/module/microsoft.powershell.core/about/about_commonparameters?view=powershell-7.5
This reverts commit 460e413. the CI passed in OpenVoxProject#41. but the CI was flawed and the related winrm_transport check wasn't triggered, because it only runs when specific files changed.
This fixes a regression introduced in 573cdb5 / OpenVoxProject#28. We run bolt on a couple of containers and valid the resultset. A Puppet 6 container was removed, but the test still expected the result from that. This wasn't noticed in CI, because the tests were only executed when specific files changed, and that wasn't triggered in this specific case. We cleaned up CI and all jobs now run always.
Use the port value for puppet_7_node, which is now used in testing instead of puppet_6_node. This plan is tightly coupled with the test in spec/integration/parallel_spec.rb "finishes executing the block then raises an error when there's an error". In 573cdb5 the puppet 6 node was removed from testing and the puppet 7 node was used to replace it. This plan relied on matching the port value of the puppet 6 node to decide to run a failing task, but the puppet 7 node has a different port number.
austb
commented
Sep 14, 2025
Contributor
Author
austb
left a comment
austb
left a comment
There was a problem hiding this comment.
I have reviewed the commits in this PR that I did not author and they look good to me 👍🏻
Someone with write access will need to review my commit and approve/merge this PR
bastelfreak
changed the title
sebastianrakel
approved these changes
Sep 15, 2025
jay7x
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the port value for puppet_7_node, which is now used in testing
instead of puppet_6_node.
This plan is tightly coupled with the test in
spec/integration/parallel_spec.rb "finishes executing the block then
raises an error when there's an error".
In 573cdb5 the puppet 6 node was
removed from testing and the puppet 7 node was used to replace it.
This plan relied on matching the port value of the puppet 6 node to
decide to run a failing task, but the puppet 7 node has a different port
number.