Skip to content

[Bug]: virtual fact not working on Windows on Proxmox non Amazaon KVM #128

Description

@Hedius

Is this a critical security issue?

  • This is not a security issue.

Describe the Bug

The virtual fact on Windows works by checking the model/manufacturer against a regex.

https://github.com/OpenVoxProject/openfact/blob/main/lib/facter/resolvers/windows/virtualization.rb#L52

This results in the fact returning physical.

Example for the manufacture under proxmoxr: QEMU

Pull requests incoming soon tm. :)

Expected Behavior

Windows on Proxmox should return virtual = kvm
like it does on Linux hosts.

Steps to Reproduce

  1. Use proxmox / kvm as a hypervisor
  2. use windows as your guest OS
  3. fact returns physical

Environment

Version OpenVox 8.28.0
Platform Windows Server 2019 / Proxmox Virtual Environment 2019

Additional Context

No response

Relevant log output

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions