Deprecate Resolvable#limit compatibility bridge for timeout#115
Draft
silug wants to merge 2 commits intoOpenVoxProject:mainfrom
Draft
Deprecate Resolvable#limit compatibility bridge for timeout#115silug wants to merge 2 commits intoOpenVoxProject:mainfrom
silug wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
`limit` was added to avoid a naming conflict with `Timeout.timeout` overwriting the `attr_reader`. Move internal callers in value to use `@timeout || 0` directly so the deprecation warning only fires for external callers. Closes OpenVoxProject#91 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
The before block stubs Facter::Log.new, which inadvertently intercepts Facter.logger's lazy @logger ||= Log.new(self) initializer. When the invalid-UTF-8 test calls Facter.send(:logger), the RSpec spy gets stored in Facter's module-level @logger. After the example ends the spy is torn down but the stale reference persists, causing spec_random failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
limitwas added to avoid a naming conflict withTimeout.timeoutoverwriting theattr_reader. Move internal callers in value to use@timeout || 0directly so the deprecation warning only fires for external callers.Closes #91
Checklist
I have:
Signed-off-byannotation to each of my commits