rubocop fixes (batch 2)

* fix Style/HashConversion
* fix Style/MapToHash
* fix Style/InverseMethods
* fix Style/SlicingWithRange
* fix Lint/NonAtomicFileOperation
* fix Performance/MapCompact
* fix Style/RedundantInterpolation
* fix Style/RedundantParentheses
* fix Lint/AmbiguousRange
* fix Lint/AssignmentInCondition
* fix Performance/DeletePrefix
* fix Performance/Detect
* fix Performance/StringInclude
* fix Style/CombinableLoops
* fix Layout/IndentationWidth
* fix Layout/IndentationConsistency
* fix Layout/CommentIndentation
* fix Style/CommentedKeyword
* fix Layout/CommentIndentation
* fix Style/HashTransformKeys
* fix Style/SymbolProc
* fix Style/HashTransformValues
* fix Style/MinMaxComparison
* fix Style/RaiseArgs
* fix Style/RedundantSort
* fix Style/SafeNavigation
* fix Style/SpecialGlobalVars
* fix Layout/BlockAlignment
* fix Layout/IndentationWidth
* fix Layout/IndentationConsistency
* fix Layout/CommentIndentation
* fix Style/IfUnlessModifier
* fix Style/StringConcatenation
* fix Style/FrozenStringLiteralComment
* fix/disable Lint/DuplicateBranch
* fix Performance/CollectionLiteralInLoop
* fix Style/OptionalBooleanParameter
* disable Style/MultilineBlockChain
* fix Style/ClassVars
* fix Style/ClassAndModuleChildren
* fix Naming/VariableNumber
* fix Naming/PredicateMethod
* fix Naming/PredicatePrefix
* fix Lint/SuppressedException
* fix Naming/HeredocDelimiterNaming
* fix Style/OpenStructUse
* fix Rake/MethodDefinitionInTask

Author: jay7x

.rubocop.yml

@@ -11,3 +11,10 @@ AllCops:
     - spec/fixtures/**/*
     - externalsources/**/*
     - output/**/*
+
+Style/StringConcatenation:
+  Details: See https://github.com/rubocop/rubocop/issues/9144
+  Mode: conservative
+
+Style/MultilineBlockChain:
+  Enabled: false

.rubocop_todo.yml

@@ -1,56 +1,22 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-02-04 04:17:01 UTC using RuboCop version 1.81.7.
+# on 2026-02-11 01:56:56 UTC using RuboCop version 1.81.7.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
-# Configuration parameters: Severity.
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'puppet_docs.gemspec'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: RequireParenthesesForMethodChains.
-Lint/AmbiguousRange:
-  Exclude:
-    - 'lib/puppet_docs/auto_redirects.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'source/_plugins/partial.rb'
-
-# Offense count: 4
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
 Lint/DuplicateBranch:
   Exclude:
-    - 'lib/puppet_references/puppet/type.rb'
     - 'source/_plugins/check_links_hook.rb'
-    - 'source/_plugins/sitemap_generator.rb'
 
 # Offense count: 1
 Lint/MixedRegexpCaptureTypes:
   Exclude:
     - 'source/_plugins/partial.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/NonAtomicFileOperation:
-  Exclude:
-    - 'Rakefile'
-
-# Offense count: 1
-# Configuration parameters: AllowComments, AllowNil.
-Lint/SuppressedException:
-  Exclude:
-    - 'source/_plugins/sitemap_generator.rb'
-
 # Offense count: 5
 Naming/AccessorMethodName:
   Exclude:
@@ -59,253 +25,23 @@ Naming/AccessorMethodName:
     - 'lib/puppet_references/puppet/type_strings.rb'
     - 'lib/puppet_references/version_tables/data/agent.rb'
 
-# Offense count: 3
-# Configuration parameters: ForbiddenDelimiters.
-# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'lib/puppet_references/puppet/man.rb'
-    - 'lib/puppet_references/util.rb'
-    - 'source/_plugins/partial.rb'
-
-# Offense count: 1
-# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
-# AllowedMethods: call
-# WaywardPredicates: nonzero?
-Naming/PredicateMethod:
-  Exclude:
-    - 'source/_plugins/sitemap_generator.rb'
-
-# Offense count: 1
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros, UseSorbetSigs.
-# NamePrefix: is_, has_, have_, does_
-# ForbiddenPrefixes: is_, has_, have_, does_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicatePrefix:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/puppet_references.rb'
-
-# Offense count: 2
-# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
-# SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
-Naming/VariableNumber:
-  Exclude:
-    - 'lib/puppet_references.rb'
-    - 'lib/puppet_references/version_tables/data/agent.rb'
-
-# Offense count: 2
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'lib/puppet_references/puppet/type.rb'
-    - 'lib/puppet_references/version_tables/data/pe.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SafeMultiline.
-Performance/DeletePrefix:
-  Exclude:
-    - 'lib/puppet_docs/config.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/Detect:
-  Exclude:
-    - 'source/_plugins/markdown_blocks.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/MapCompact:
-  Exclude:
-    - 'lib/puppet_docs/config.rb'
-    - 'lib/puppet_docs/versions.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/StringInclude:
-  Exclude:
-    - 'lib/puppet_references/version_tables/data/pe.rb'
-
 # Offense count: 11
 # This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 2
-Rake/MethodDefinitionInTask:
-  Exclude:
-    - 'Rakefile'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
-# SupportedStyles: nested, compact
-# SupportedStylesForClasses: ~, nested, compact
-# SupportedStylesForModules: ~, nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'source/_plugins/sitemap_generator.rb'
-
-# Offense count: 3
-Style/ClassVars:
-  Exclude:
-    - 'lib/puppet_references/puppet/strings.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/CombinableLoops:
-  Exclude:
-    - 'lib/puppet_docs/config.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/CommentedKeyword:
-  Exclude:
-    - 'lib/puppet_references/util.rb'
-
 # Offense count: 43
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
 
-# Offense count: 57
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 5
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Exclude:
-    - 'util/bbedit_tools/Markdown_with_kramdown.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowSplatArgument.
-Style/HashConversion:
-  Exclude:
-    - 'lib/puppet_references/version_tables/data/agent.rb'
-    - 'lib/puppet_references/version_tables/data/pe.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/HashTransformKeys:
-  Exclude:
-    - 'lib/puppet_references/util.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/HashTransformValues:
-  Exclude:
-    - 'lib/puppet_docs/config.rb'
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-Style/IfUnlessModifier:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/puppet_references/puppet/type_strings.rb'
-    - 'lib/puppet_references/quarantine/get_typedocs.rb'
-    - 'lib/puppet_references/version_tables/data/agent.rb'
-    - 'lib/puppet_references/version_tables/data/pe.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: InverseMethods, InverseBlocks.
-Style/InverseMethods:
-  Exclude:
-    - 'lib/puppet_docs/config.rb'
-    - 'lib/puppet_references/puppet/man.rb'
-    - 'source/_plugins/limited_preview_hook.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/MinMaxComparison:
-  Exclude:
-    - 'source/_plugins/sitemap_generator.rb'
-
 # Offense count: 1
 Style/MixinUsage:
   Exclude:
     - 'lib/puppet_references/quarantine/get_typedocs.rb'
 
-# Offense count: 3
-Style/MultilineBlockChain:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/puppet_references/puppet/type_strings.rb'
-    - 'source/_plugins/change_baseurl.rb'
-
-# Offense count: 2
-Style/OpenStructUse:
-  Exclude:
-    - 'lib/puppet_references/puppet/functions.rb'
-    - 'lib/puppet_references/puppet/type.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: respond_to_missing?
-Style/OptionalBooleanParameter:
-  Exclude:
-    - 'lib/puppet_references/puppet/strings.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Exclude:
-    - 'source/_plugins/partial.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/RedundantInterpolation:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/puppet_references/puppet/man.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/RedundantSort:
-  Exclude:
-    - 'lib/puppet_references/version_tables/data/agent.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'source/_plugins/partial.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/SlicingWithRange:
-  Exclude:
-    - 'lib/puppet_docs/auto_redirects.rb'
-    - 'lib/puppet_references/repo.rb'
-    - 'source/_plugins/partial.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: RequireEnglish.
-# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names
-Style/SpecialGlobalVars:
-  EnforcedStyle: use_perl_names
-
-# Offense count: 64
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Enabled: false
-
-# Offense count: 45
+# Offense count: 42
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org/'
 gemspec name: 'puppet_docs'