Enable HTMLProofer Images check and remove orphaned openvox images

[miharp]

Background

Raised by @binford2k: most images in docs/_openvox_8x/images are no longer relevant and should be removed. While checking, we found the link checker does not validate images.

Our rake test:links runs HTMLProofer scoped to checks: ['Links'] (Rakefile), so only <a href> links are validated. HTMLProofer's default checks is ['Links', 'Images', 'Scripts'], and the Images check validates that internal image references aren't broken — we've opted out of it, so a broken <img> (e.g. after deleting an image that's still referenced) won't fail CI.

Proposed work

1. Enable the Images check

Add 'Images' to the checks: array in the test:links task (Rakefile). Existing config already mitigates the noisy parts:

• disable_external: true → external images aren't fetched
• ignore_empty_alt: true → empty alt="" won't fail

Heads-up: turning this on may surface pre-existing broken image references across all collections (not just openvox), so a first pass to fix/audit those is likely needed before it can go green in CI.

2. Remove orphaned openvox images

12 of the 33 files in docs/_openvox_8x/images have zero references anywhere in the docs and can be deleted immediately:

environment_directories.svg
forge_add_module.png
forge_add_release.png
forge_register.png
forge_upload.png
os-x-signature-gui-1.png
os-x-signature-gui-2.png
puppet agent downloads.png
windows_invalid_signature.png
windows_package_signatures.png
wizard_server.png
yourmodules.png

The other 21 are still referenced by pages (Forge-upload walkthrough, module-deletion flow, Windows signature screenshots, etc.). Trimming those further means removing/updating the referencing pages too — and with the Images check enabled, CI would then catch any image refs left dangling.

[miharp]

Ran the Images check to scope the work

Ran HTMLProofer across all 7 collections (455 files) with the existing test:links config plus checks: ['Images'] (and ignore_missing_alt: true to focus on broken files, not alt text). Result: 2 failures, both on a single page, and both effectively false positives.

For the Images check, the following failures were found:
* At _site/openbolt/latest/bolt_command_reference.html:8960: image has no src or srcset attribute
* At _site/openbolt/latest/bolt_command_reference.html:9179: image has no src or srcset attribute
HTML-Proofer found 2 failures!

Root cause — bolt CLI usage syntax in that generated page:

bolt file download <source> <destination> ...
bolt file upload   <source> <destination> ...

The <source> isn't escaped in the code block, so it leaks a real (empty) <source> element into the HTML (confirmed: 2 unescaped <source />, 0 escaped <source>). HTMLProofer's Images check reads <source> as a media element and flags the missing src.

Takeaways

• No genuine broken images anywhere — every referenced image across all collections resolves (including the 21 referenced openvox images). So the check would correctly catch a referenced image being deleted, which is exactly the safety net we want for the orphan cleanup.
• The only blocker to enabling the check is this one generated openbolt page. Note it's also a OpenBolt generated reference pages return 404 #202 generated page that only renders after the front-matter fix — on current CI it 404s, so these failures wouldn't even surface until OpenBolt generated reference pages return 404 #202 ships.

Enablement options

1. Proper fix: escape <source> / <destination> in the openbolt command-reference generator (upstream OpenVoxProject/openbolt), then add 'Images' to the checks: array here.
2. Quick unblock: add 'Images' now and add an HTMLProofer ignore for the <source>/<destination> case (or that page) until the upstream fix lands.

Either way, the orphaned-image deletion (part 2) is unblocked today and independent of this.