Skip to content

Add CI job to build the site#12

Closed
bastelfreak wants to merge 10 commits into
masterfrom
ci2
Closed

Add CI job to build the site#12
bastelfreak wants to merge 10 commits into
masterfrom
ci2

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread source/_config.yml
externalsources:
/mcollective:
repo: git@github.com:choria-legacy/marionette-collective.git
repo: https://github.com/choria-legacy/marionette-collective.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep mcollective?

Comment thread Gemfile
gem 'rack', '>= 2.2.14'
gem 'git', '~> 4.0'
gem 'rack', '~> 2.2', '>= 2.2.3'
gem 'git', '~> 1.8'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to lower the versions?

Comment thread Gemfile
group(:unknown) do
gem 'maruku', '~> 0.7'
gem 'activerecord', '>= 7.1.5.2'
gem 'activerecord', '~>6'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to lower the version?

tuxmea added a commit that referenced this pull request Jan 30, 2026
tuxmea added a commit that referenced this pull request Jan 30, 2026
@tuxmea
Copy link
Copy Markdown
Contributor

tuxmea commented Feb 4, 2026

Already in master, except for Gemfile.lock.
Should we keep the Gemfile.lock? I saw that it causes issues with architecture (linux vs mac os)

@Sharpie
Copy link
Copy Markdown
Member

Sharpie commented Apr 16, 2026

Should we keep the Gemfile.lock?

Having Gemfile.lock would make it easier for folks to build historical versions of the site as Bundler would use those historical dependencies instead of re-solving and possibly failing.

I think bundle lock --add-platform should be able to produce a Gemfile.lock that works across macOS and Linux.

Copy link
Copy Markdown
Contributor

@tuxmea tuxmea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can close this one

@tuxmea
Copy link
Copy Markdown
Contributor

tuxmea commented Apr 21, 2026

We have a build process in place. Closing.

@tuxmea tuxmea closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants